Skip to content

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Aug 30, 2023

What does this PR try to resolve?

This is the implementation of MCP rust-lang/compiler-team#667.

Also fixes #74722

How should we test and review this PR?

  • The first commit demonstrates the current behavior.
  • The second moves code without any behavior change.
  • The last commit is the meaty part of the MCP, including UI snapshot changes.

Additional information

A bit unfortunate this brings some diagnostic duplications. I am not familiar enough with the codebase to eliminiate them. Will appreciate if someone can give pointers. (Or, we can defer this to follow-up PRs?)

This demonstrates the current behavior of adding lint form the command
line. generally the lint levels are ignored as the current implementation
unconditionally emit errors for those lints.
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2023
@rust-log-analyzer

This comment has been minimized.

@weihanglo weihanglo force-pushed the merge-check-and-lint branch from 7404b6a to dc675de Compare August 30, 2023 16:35
@rust-log-analyzer

This comment has been minimized.

@weihanglo weihanglo force-pushed the merge-check-and-lint branch from dc675de to a11805a Compare August 30, 2023 18:25
@weihanglo weihanglo marked this pull request as draft August 30, 2023 18:27
@weihanglo weihanglo marked this pull request as ready for review August 30, 2023 19:00
@weihanglo
Copy link
Member Author

r? @estebank

If you've got time to review this :)

@oli-obk
Copy link
Contributor

oli-obk commented Sep 11, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 11, 2023

📌 Commit a11805a has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2023
@bors
Copy link
Collaborator

bors commented Sep 11, 2023

⌛ Testing commit a11805a with merge 5d62ab8...

@bors
Copy link
Collaborator

bors commented Sep 11, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 5d62ab8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2023
@bors bors merged commit 5d62ab8 into rust-lang:master Sep 11, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 11, 2023
@weihanglo weihanglo deleted the merge-check-and-lint branch September 11, 2023 10:48
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5d62ab8): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.2%, 1.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-3.5%, -1.6%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.224s -> 629.427s (-0.13%)
Artifact size: 317.56 MiB -> 317.62 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing -W for an unknown lint gives an error without saying why
8 participants