Skip to content

Conversation

onur-ozkan
Copy link
Contributor

bumped pretty_assertations in favor of removing duplicated syn, and bumped hermit-abi from the yanked version.

Removes the duplicated dependency(syn 1.0.102) from bootstrap dependency tree

Signed-off-by: onur-ozkan <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 1, 2023
@rust-log-analyzer

This comment has been minimized.

@onur-ozkan onur-ozkan force-pushed the optimize-bootstrap-dep-tree branch from c219660 to 2a5a6bc Compare September 1, 2023 18:04
@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

📌 Commit 2a5a6bc has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
@bors
Copy link
Collaborator

bors commented Sep 3, 2023

⌛ Testing commit 2a5a6bc with merge 49523e3...

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 49523e3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023
@bors bors merged commit 49523e3 into rust-lang:master Sep 3, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (49523e3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.237s -> 631.425s (0.51%)
Artifact size: 316.75 MiB -> 316.57 MiB (-0.06%)

@onur-ozkan onur-ozkan deleted the optimize-bootstrap-dep-tree branch January 27, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants