Skip to content

Turn assert_eq into a delay_span_bug #117811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

Turn assert_eq into a delay_span_bug #117811

merged 1 commit into from
Nov 13, 2023

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Nov 11, 2023 •
edited
Loading

Fixes #117789

@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2023
@mu001999
Copy link
Contributor Author

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned b-naber Nov 11, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mu001999 mu001999 changed the title Skip auto traits with generic parameters when linting auto trait impls Turn assert_eq into a delay_span_bug Nov 13, 2023
@lcnr
Copy link
Contributor

lcnr commented Nov 13, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 13, 2023

📌 Commit 62b6529 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2023
@bors
Copy link
Collaborator

bors commented Nov 13, 2023

⌛ Testing commit 62b6529 with merge 1ab2bcd...

@bors
Copy link
Collaborator

bors commented Nov 13, 2023

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 1ab2bcd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 13, 2023
@bors bors merged commit 1ab2bcd into rust-lang:master Nov 13, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 13, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1ab2bcd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.1% [-3.2%, -0.9%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.7% [-3.2%, 2.1%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.362s -> 673.14s (-0.18%)
Artifact size: 311.11 MiB -> 311.09 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

ice: auto traits: assertion failed 1 == 2
8 participants
@mu001999 @rustbot @rust-log-analyzer @lcnr @bors @rust-timer @compiler-errors @b-naber