Skip to content

bootstrap: only show PGO warnings when verbose #117982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

bootstrap: only show PGO warnings when verbose #117982

merged 1 commit into from
Nov 17, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Nov 16, 2023

Building rustc with --rust-profile-use is currently dumping a lot of
warnings of "no profile data available for function" from rustc_smir
and stable_mir. These simply aren't exercised by the current profile-
gathering steps, but that's to be expected for new or experimental
functionality. I think for most people, these warnings will be just
noise, so it makes sense to only have them in verbose builds.

@cuviper
bootstrap: only show PGO warnings when verbose
776146e 
Building rustc with `--rust-profile-use` is currently dumping a lot of
warnings of "no profile data available for function" from `rustc_smir`
and `stable_mir`. These simply aren't exercised by the current profile-
gathering steps, but that's to be expected for new or experimental
functionality. I think for most people, these warnings will be just
noise, so it makes sense to only have them in verbose builds.
@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2023

r? @onur-ozkan

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 16, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_a647ecff-d191-46ad-b38e-62df7ffa726e
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://github.com/api/graphql
GITHUB_HEAD_REF=quiet-pgo
GITHUB_JOB=pr
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_a647ecff-d191-46ad-b38e-62df7ffa726e
GITHUB_REF=refs/pull/117982/merge
GITHUB_REF_NAME=117982/merge
GITHUB_REF_PROTECTED=false
---
command: "Building dependencies"
Error: 
   0: tests failed

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
full stderr:
previous build failed
full stdout:

@cuviper
Copy link
Member Author

cuviper commented Nov 16, 2023

Those failures are "warning: spurious network error".

@Kobzol
Copy link
Contributor

Kobzol commented Nov 16, 2023

These warnings are indeed a bit annoying on CI, but I still think that it would be nice if we saw the PGO warnings in CI logs, to spot potential PGO regressions. So I would prefer either filtering only some of the crates (probably hard to do), or make sure that we use verbose builder on CI? 🤔

@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 16, 2023

📌 Commit 776146e has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@onur-ozkan
Copy link
Member

onur-ozkan commented Nov 16, 2023 •
edited
Loading

These warnings are indeed a bit annoying on CI, but I still think that it would be nice if we saw the PGO warnings in CI logs, to spot potential PGO regressions. So I would prefer either filtering only some of the crates (probably hard to do), or make sure that we use verbose builder on CI? 🤔

Enabling verbose mode on CI shouldn't cause any harm I think. If we're not already doing so, we should consider turning it on.

I still think that it would be nice if we saw the PGO warnings in CI logs

This should definetly be handled with turning the verbosity instead of printing the logs by default.

@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@bors
Auto merge of rust-lang#117996 - matthiaskrgr:rollup-sp48bl4, r=matth…
f2f526c 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#117892 (Detect more `=>` typos)
 - rust-lang#117959 (Better handle type errors involving `Self` literals)
 - rust-lang#117980 (fix: Update CONTRIBUTING.md recommend -> recommended)
 - rust-lang#117982 (bootstrap: only show PGO warnings when verbose)
 - rust-lang#117990 (Tweak error and move tests)

Failed merges:

 - rust-lang#117944 (some additional region refactorings)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f82fefd into rust-lang:master Nov 17, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 17, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@rust-timer
Unrolled build for rust-lang#117982
45d6d07 
Rollup merge of rust-lang#117982 - cuviper:quiet-pgo, r=onur-ozkan

bootstrap: only show PGO warnings when verbose

Building rustc with `--rust-profile-use` is currently dumping a lot of
warnings of "no profile data available for function" from `rustc_smir`
and `stable_mir`. These simply aren't exercised by the current profile-
gathering steps, but that's to be expected for new or experimental
functionality. I think for most people, these warnings will be just
noise, so it makes sense to only have them in verbose builds.
@cuviper cuviper deleted the quiet-pgo branch November 17, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cuviper @rustbot @rust-log-analyzer @Kobzol @onur-ozkan @bors