Clippy subtree sync #118507

flip1995 · 2023-12-01T17:23:08Z

Co-authored-by: Catherine Flores <[email protected]>

This action was way outdated, produced a lot of warnings and didn't seem to work anymore.

…Alexendoo Update rust-cache GHA in deploy workflow This action was way outdated, produced a lot of warnings and didn't seem to work anymore. changelog: none

This was made possible by the removal of plugin support, which simplified lint store creation. This simplifies the places in rustc and rustdoc that call `describe_lints`, which are early on. The lint store is now built before those places, so they don't have to create their own lint store for temporary use, they can just use the main one.

- `erase_late_bound_regions` -> `instantiate_bound_regions_with_erased` - `replace_late_bound_regions_X` -> `instantiate_bound_regions_X`

Fix typo Fix a little spelling error. changelog: none

Extend `maybe_misused_cfg` lint over `cfg(test)` Fixes rust-lang#11240. One thought I had is that we could use the levenshtein distance (of 1) to ensure this is indeed `test` that was targeted. But maybe it's overkill, not sure. changelog: [`maybe_misused_cfg`]: Extend lint over `cfg(test)` r? `@blyxyas`

Rustup r? `@ghost` changelog: none

…ubtree-sync

rustbot · 2023-12-01T17:23:18Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

matthiaskrgr · 2023-12-01T22:23:43Z

@bors r+ rollup=never p=1

bors · 2023-12-01T22:23:46Z

📌 Commit 6ae8003 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-12-01T23:55:52Z

⌛ Testing commit 6ae8003 with merge 0a8d815...

…hiaskrgr Clippy subtree sync r? `@Manishearth`

bors · 2023-12-02T00:02:56Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-12-02T00:03:24Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2493/3236] Building CXX object lib/Target/X86/MCTargetDesc/CMakeFiles/LLVMX86Desc.dir/X86ATTInstPrinter.cpp.o
[2494/3236] Building CXX object lib/Target/X86/MCTargetDesc/CMakeFiles/LLVMX86Desc.dir/X86InstPrinterCommon.cpp.o

##[group]Clock drift check
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
  network time: Sat, 02 Dec 2023 00:02:03 GMT
##[endgroup]
[2495/3236] Building CXX object lib/Target/X86/MCTargetDesc/CMakeFiles/LLVMX86Desc.dir/X86EncodingOptimization.cpp.o
[2496/3236] Building CXX object lib/Target/X86/MCTargetDesc/CMakeFiles/LLVMX86Desc.dir/X86MCAsmInfo.cpp.o
---
[2539/3236] Building CXX object lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kInstructionSelector.cpp.o
[2540/3236] Building CXX object lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kRegisterBankInfo.cpp.o
[2541/3236] Building CXX object lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/M68kExpandPseudo.cpp.o
[2542/3236] Building CXX object lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/M68kCollapseMOVEMPass.cpp.o
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

matthiaskrgr · 2023-12-02T10:30:23Z

@bors retry

bors · 2023-12-02T11:41:59Z

⌛ Testing commit 6ae8003 with merge 7be0546...

bors · 2023-12-02T13:37:39Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7be0546 to master...

rust-timer · 2023-12-02T14:59:21Z

Finished benchmarking commit (7be0546): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.0%, 2.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.7%, -2.5%]	2
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.139s -> 671.874s (-0.04%)
Artifact size: 313.94 MiB -> 313.92 MiB (-0.00%)

…hiaskrgr Clippy subtree sync r? `@Manishearth`

y21 and others added 30 commits November 2, 2023 23:53

teach eager_or_lazy that arithmetic ops can panic

c9d2961

Lint flatten() under lines_filter_map_ok

39eded7

Use match on method args instead of if let

1032009

Split arg/method checking into its own function

10f3977

Use fm_method_str in lint formatting

c50af35

Co-authored-by: Catherine Flores <[email protected]>

Fix formatting

4388158

Make macro_use_imports lint ordering more stable

d8c0e64

fix iter_kv_map dont suggest into_keys and into_values if msrv is to low

5f651da

[ptr_arg]: recognize methods that also exist on slices

bb69461

replace Vec with slice in lintcheck

3e83a52

[redundant_guards]: lint empty string checks

ef587d2

[redundant_guards]: lint empty slice checks

998a311

[redundant_guards]: lint slice::{starts_with,ends_with}

676f1f6

fix empty needle corner case and add tests

1b4e2ef

dogfood clippy

8f9c738

lint when relevant sides of binops are constants

23ee332

[match_same_arms]: respect allow attrs on arms

1e0597c

allow more div and rem operations that can be checked

7696c9d

Extend maybe_misused_cfg lint over cfg(test)

74451cd

Add UI test for mispelled test

a621d71

Update documentation for MAYBE_MISUSED_CFG lint

f08037c

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

6246f04

Update rust-cache GHA in deploy workflow

8d89cc4

This action was way outdated, produced a lot of warnings and didn't seem to work anymore.

Auto merge of rust-lang#11824 - flip1995:ci-update-rust-cache-gha, r=…

edefa97

…Alexendoo Update rust-cache GHA in deploy workflow This action was way outdated, produced a lot of warnings and didn't seem to work anymore. changelog: none

simplify matching on binop result

aca4086

fix typo

4143acf

rename bound region instantiation

8c6c542

- `erase_late_bound_regions` -> `instantiate_bound_regions_with_erased` - `replace_late_bound_regions_X` -> `instantiate_bound_regions_X`

Auto merge of rust-lang#11828 - CleanCut:patch-1, r=xFrednet

25f4f85

Fix typo Fix a little spelling error. changelog: none

flip1995 and others added 4 commits December 1, 2023 18:06

Merge remote-tracking branch 'upstream/master' into rustup

a9867e1

Bump nightly version -> 2023-12-01

9d36c18

Auto merge of rust-lang#11903 - flip1995:rustup, r=flip1995

f0cdee4

Rustup r? `@ghost` changelog: none

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-s…

6ae8003

…ubtree-sync

rustbot assigned Manishearth Dec 1, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2023

Auto merge of rust-lang#118507 - flip1995:clippy-subtree-sync, r=matt…

0a8d815

…hiaskrgr Clippy subtree sync r? `@Manishearth`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2023

bors merged commit 7be0546 into rust-lang:master Dec 2, 2023

rustbot added this to the 1.76.0 milestone Dec 2, 2023

This was referenced Dec 2, 2023

Add lint against ambiguous wide pointer comparisons #117758

Merged

Merge unused_tuple_struct_fields into dead_code #118297

Merged

Add support for gen fn #118457

Merged

flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 16, 2023

Auto merge of rust-lang#118507 - flip1995:clippy-subtree-sync, r=matt…

c586717

…hiaskrgr Clippy subtree sync r? `@Manishearth`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clippy subtree sync #118507

Clippy subtree sync #118507

flip1995 commented Dec 1, 2023

rustbot commented Dec 1, 2023

matthiaskrgr commented Dec 1, 2023

bors commented Dec 1, 2023

bors commented Dec 1, 2023

bors commented Dec 2, 2023

rust-log-analyzer commented Dec 2, 2023

matthiaskrgr commented Dec 2, 2023

bors commented Dec 2, 2023

bors commented Dec 2, 2023

rust-timer commented Dec 2, 2023

Clippy subtree sync #118507

Clippy subtree sync #118507

Conversation

flip1995 commented Dec 1, 2023

rustbot commented Dec 1, 2023

matthiaskrgr commented Dec 1, 2023

bors commented Dec 1, 2023

bors commented Dec 1, 2023

bors commented Dec 2, 2023

rust-log-analyzer commented Dec 2, 2023

matthiaskrgr commented Dec 2, 2023

bors commented Dec 2, 2023

bors commented Dec 2, 2023

rust-timer commented Dec 2, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size