Avoid overflow in GVN constant indexing. #119052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
| from_end: false, | ||
| }; | ||
| projection.to_mut()[i] = | ||
| ProjectionElem::ConstantIndex { offset, min_length, from_end: false }; |
There was a problem hiding this comment.
Do you know why ConstantIndex stores min_length instead of, e.g., the "max index" of the last value?
There was a problem hiding this comment.
Well I guess it doesn't make sense to index at usize::MAX anyways.
There was a problem hiding this comment.
min_length comes from slice match. I supposed it's easier to compute from the length of the pattern.
compiler-errors
approved these changes
Dec 17, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 17, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#118880 (More expressions correctly are marked to end with curly braces) - rust-lang#118928 (fix: Overlapping spans in delimited meta-vars) - rust-lang#119022 (Remove unnecessary constness from ProjectionCandidate) - rust-lang#119052 (Avoid overflow in GVN constant indexing.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 17, 2023
Rollup merge of rust-lang#119052 - cjgillot:gvn-index-overflow, r=compiler-errors Avoid overflow in GVN constant indexing. Fixes rust-lang#118992 Fixes rust-lang#119008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118992
Fixes #119008