Skip to content

match lowering: Remove the make_target_blocks hack #119112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

match lowering: Remove the make_target_blocks hack #119112

merged 1 commit into from
Dec 19, 2023

Conversation

Nadrieril
Copy link
Member

This hack was introduced 4 years ago in a1d0266 (#60730) to improve LLVM optimization time, specifically noticed in the encoding benchmark. Measurements today indicate it is no longer needed.

r? @matthewjasper

@Nadrieril
Remove the make_target_blocks hack
31bad13 
It was introduced 4 years ago in a1d0266 to improve LLVM
optimization time. Measurements today indicate it is no longer needed.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2023
@Nadrieril
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2023
@bors
Copy link
Collaborator

bors commented Dec 19, 2023

⌛ Trying commit 31bad13 with merge bbc076f...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2023
@bors
Auto merge of rust-lang#119112 - Nadrieril:remove-target_blocks-hack,…
bbc076f 
… r=<try>

match lowering: Remove the `make_target_blocks` hack

This hack was introduced 4 years ago in [`a1d0266` (rust-lang#60730)](rust-lang@a1d0266) to improve LLVM optimization time, specifically noticed in the `encoding` benchmark. Measurements today indicate it is no longer needed.

r? `@matthewjasper`
@Nadrieril Nadrieril mentioned this pull request Dec 19, 2023
Closed
@lqd
Copy link
Member

lqd commented Dec 19, 2023 •
edited
Loading

specifically noticed in the encoding benchmark. Measurements today indicate it is no longer needed.

Maybe try it locally with rustc-perf to make sure? We only run this benchmark as part of the "stable" benchmarks, not on every PR anymore (since rust-lang/rustc-perf@ce8ad46).

@Nadrieril
Copy link
Member Author

Oh damn I did not notice that. Will do!

@Nadrieril
Copy link
Member Author

Nadrieril commented Dec 19, 2023 •
edited
Loading

I measure only a 0.15% regression locally!

@Nadrieril
Copy link
Member Author

It would be nice to have a rust-perf option to run the stable-only benchmarks, I don't fully trust my local measurements (though for once they seem consistent)

@bors
Copy link
Collaborator

bors commented Dec 19, 2023

☀️ Try build successful - checks-actions
Build commit: bbc076f (bbc076f84d54330419a5c50bd2e5176f89dc85ea)

@rust-timer

This comment has been minimized.

Sign in to view
@Nadrieril Nadrieril mentioned this pull request Dec 19, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bbc076f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.2%, 2.9%] 7
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 1

Bootstrap: 671.446s -> 672.298s (0.13%)
Artifact size: 312.47 MiB -> 312.51 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2023
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 19, 2023

📌 Commit 31bad13 has been approved by matthewjasper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2023
@Nadrieril
Copy link
Member Author

Thank you! Do you know when the stable benchmarks are run on CI?

@lqd
Copy link
Member

lqd commented Dec 19, 2023

IIRC for each stable release for the perf dashboard.

@bors
Copy link
Collaborator

bors commented Dec 19, 2023

⌛ Testing commit 31bad13 with merge f704f3b...

@Nadrieril Nadrieril added the A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Dec 19, 2023
@bors
Copy link
Collaborator

bors commented Dec 19, 2023

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing f704f3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 19, 2023
@bors bors merged commit f704f3b into rust-lang:master Dec 19, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 19, 2023
@Nadrieril Nadrieril deleted the remove-target_blocks-hack branch December 19, 2023 23:31
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f704f3b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.3% [-2.0%, -0.6%] 2
Improvements ✅
(secondary)		 -3.7% [-3.8%, -3.6%] 2
All ❌✅ (primary) -1.3% [-2.0%, -0.6%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 1

Bootstrap: 671.988s -> 674.398s (0.36%)
Artifact size: 312.43 MiB -> 312.41 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Nadrieril @rust-timer @bors @lqd @matthewjasper @rustbot