fix: diagnostic for casting reference to slice #119175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
There are cases in which it would be better to suggest removing the cast, for example: let _: &[u16] = &[1] as [u16];
// removing a cast is ok, there is a
// &[u16; 1] -> &[u16] coercionhowever, I'm not sure we can distinguish those cases from the cases where this wouldn't be possible (because there is no guidance that would force the coercion). |
WaffleLapkin
approved these changes
Dec 27, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2023
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#119175 (fix: diagnostic for casting reference to slice) - rust-lang#119337 (Remove dead codes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2023
Rollup merge of rust-lang#119175 - veera-sivarajan:fix-cast-to-slice, r=WaffleLapkin fix: diagnostic for casting reference to slice fixes: rust-lang#118790 Removes `if self.cast_ty.is_trait()` to produce the same diagnostic for cast to slice and trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #118790
Removes
if self.cast_ty.is_trait()to produce the same diagnostic for cast to slice and trait.