Skip to content

Conversation

Swatinem
Copy link
Contributor

Instead of having separate make_async/etc_expr functions, this merges them them into one, reducing code duplication a bit.

@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2023
@Swatinem
Copy link
Contributor Author

r? @compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned cjgillot Dec 28, 2023
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few nits

@Swatinem Swatinem force-pushed the merge-coroutine-lowering branch from 2ca908e to bd0e776 Compare December 28, 2023 18:12
@Swatinem Swatinem force-pushed the merge-coroutine-lowering branch from bd0e776 to 33105b6 Compare December 28, 2023 18:34
Instead of having separate `make_async/etc_expr` functions, this merges them them into one, reducing code duplication a bit.
@Swatinem Swatinem force-pushed the merge-coroutine-lowering branch from 33105b6 to 2480a0f Compare December 28, 2023 20:24
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 28, 2023

📌 Commit 2480a0f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119375 (Merge Coroutine lowering functions)
 - rust-lang#119393 (Use filter instead of filter_map in Parser::expected_one_of_not_found)
 - rust-lang#119401 (coverage: Avoid a possible query stability hazard in `CoverageCounters`)
 - rust-lang#119402 (Also walk bindings created by if-let guards)
 - rust-lang#119404 (Enable profiler in dist-powerpc-linux)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 559c864 into rust-lang:master Dec 29, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 29, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2023
Rollup merge of rust-lang#119375 - Swatinem:merge-coroutine-lowering, r=compiler-errors

Merge Coroutine lowering functions

Instead of having separate `make_async/etc_expr` functions, this merges them them into one, reducing code duplication a bit.
@Swatinem Swatinem deleted the merge-coroutine-lowering branch December 29, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants