-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Remove usage of to_stable_hash_key
when stable hashing hash maps
#119390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Remove usage of `to_stable_hash_key` when stable hashing hash maps I tried to look for some types that had an expensive `to_stable_hash_key` implementation and move them to `HashStable` instead. Let's see if there's any perf. impact.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (e920371): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.862s -> 673.243s (0.21%) |
Hmm, no big effect. And since #119192 will probably remove most remaining usages of hashmaps in stable hashing soon, it's probably not worth it to do this. |
I tried to look for some types that had an expensive
to_stable_hash_key
implementation and move them toHashStable
instead. Let's see if there's any perf. impact.