Skip to content

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Feb 17, 2024

It appears that the unit binding is not necessary at this time. However, I am unsure of its importance in the past. Please let me know if it is unsafe to remove.

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 17, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Not sure, but seems likely to be fine. I don't see any particularly interesting other similar cases.

@bors
Copy link
Collaborator

bors commented Feb 18, 2024

📌 Commit 6f1383c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules)
 - rust-lang#121067 (make "invalid fragment specifier" translatable)
 - rust-lang#121224 (Remove unnecessary unit binding)
 - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`)
 - rust-lang#121257 (remove extraneous text from example config)
 - rust-lang#121260 (Remove const_prop.rs)
 - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@klensy
Copy link
Contributor

klensy commented Feb 18, 2024

Kind of static assert, like

#[macro_export]
macro_rules! static_assert_size {
($ty:ty, $size:expr) => {
const _: [(); $size] = [(); ::std::mem::size_of::<$ty>()];
};
}

@codeworm96
Copy link
Contributor

As far as I know, there are different ways to do a static assert in rust:

Are there any guidelines about choosing between them?

@bors bors merged commit c8f2a00 into rust-lang:master Feb 18, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
Rollup merge of rust-lang#121224 - hi-rustin:rustin-patch-unit-binding, r=Mark-Simulacrum

Remove unnecessary unit binding

It appears that the unit binding is not necessary at this time. However, I am unsure of its importance in the past. Please let me know if it is unsafe to remove.
Noratrieb pushed a commit to Noratrieb/rust that referenced this pull request Feb 18, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules)
 - rust-lang#121067 (make "invalid fragment specifier" translatable)
 - rust-lang#121224 (Remove unnecessary unit binding)
 - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`)
 - rust-lang#121257 (remove extraneous text from example config)
 - rust-lang#121260 (Remove const_prop.rs)
 - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants