Bump windows-bindgen to 0.55.0 #122390
Merged
Bump windows-bindgen to 0.55.0 #122390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
O-windows
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Comment on lines
3845
to
+3848
| #[repr(C)] | ||
| pub struct SOCKADDR { | ||
| pub sa_family: ADDRESS_FAMILY, | ||
| pub sa_data: [u8; 14], | ||
| pub sa_data: [i8; 14], |
There was a problem hiding this comment.
The sa_data in SOCKADDR seems to be ffi::c_char:
typedef struct sockaddr {
#if ...
u_short sa_family;
#else
ADDRESS_FAMILY sa_family;
#endif
CHAR sa_data[14];
} SOCKADDR, *PSOCKADDR, *LPSOCKADDR;
|
@bors r+ It sounds to me like the above discussion resolved that this is OK, but if not we can revert/unapprove. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2024
…enton Rollup of 7 pull requests Successful merges: - rust-lang#122323 (configure.py: add flag for loongarch64 musl-root) - rust-lang#122372 (prevent notifying the same changes more than once) - rust-lang#122390 (Bump windows-bindgen to 0.55.0) - rust-lang#122401 (Check library crates for all tier 1 targets in PR CI) - rust-lang#122489 (Bump `cargo update` PR more often) - rust-lang#122583 (Use `UnsafeCell` for fast constant thread locals) - rust-lang#122590 (bootstrap: Don't name things copy that are not copies) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2024
Rollup merge of rust-lang#122390 - ChrisDenton:bindgen, r=Mark-Simulacrum Bump windows-bindgen to 0.55.0 windows-bindgen is the crate used to generate std's Windows API bindings. Not many changes for us, it's mostly just simplifying the generate code (e.g. no more `-> ()`). The one substantial change is some structs now use `i8` byte arrays instead of `u8`. However, this only impacts one test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-bindgen is the crate used to generate std's Windows API bindings.
Not many changes for us, it's mostly just simplifying the generate code (e.g. no more
-> ()). The one substantial change is some structs now usei8byte arrays instead ofu8. However, this only impacts one test.