Skip to content

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Mar 26, 2024

5 commits in a510712d05c6c98f987af24dd73cdfafee8922e6..499a61ce7a0fc6a72040084862a68b2603e770e8
2024-03-25 03:45:54 +0000 to 2024-03-26 04:17:04 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2024
@Muscraft
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

📌 Commit 3d58ef9 has been approved by Muscraft

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2024
Update cargo

1 commits in a510712d05c6c98f987af24dd73cdfafee8922e6..499a61ce7a0fc6a72040084862a68b2603e770e8
2024-03-25 03:45:54 +0000 to 2024-03-26 04:17:04 +0000
- fix: do not borrow shell across registry query (rust-lang/cargo#13647)

r? ghost

<hr>

This update includes a fix for a panic within cargo that was noted in [cargo#13646](rust-lang/cargo#13646)
@bors
Copy link
Collaborator

bors commented Mar 26, 2024

⌛ Testing commit 3d58ef9 with merge a1c1bd2...

@workingjubilee
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2024
@workingjubilee
Copy link
Member

@Muscraft This doesn't have all the diffs in the tip-of-tree for cargo since weihanglo's last subtree sync today.

@workingjubilee
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2024
@workingjubilee
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@workingjubilee
Copy link
Member

Whee.

@workingjubilee
Copy link
Member

It's not impossible I'm wrong and the generated PR description from the tool you're using simply left out a... kinda important one.

@RalfJung
Copy link
Member

The PR does seem to contain the change mentioned in the description. But then it also contains more that's somehow not mentioned...

@workingjubilee
Copy link
Member

We did some noodling on things and found the correct set of updates.

@workingjubilee
Copy link
Member

@bors r=Muscraft,workingjubilee

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

📌 Commit 3d58ef9 has been approved by Muscraft,workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2024
@bors
Copy link
Collaborator

bors commented Mar 26, 2024

⌛ Testing commit 3d58ef9 with merge b13a71a...

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

☀️ Test successful - checks-actions
Approved by: Muscraft,workingjubilee
Pushing b13a71a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 26, 2024
@bors bors merged commit b13a71a into rust-lang:master Mar 26, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 26, 2024
@RalfJung RalfJung mentioned this pull request Mar 26, 2024
bors added a commit to rust-lang/miri that referenced this pull request Mar 26, 2024
Rustup

rust-lang/rust#123081 landed so hopefully this works now.
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  PR_MESSAGE: Automation to keep dependencies in `Cargo.lock` current.
following is the output from `cargo update`:
  COMMIT_MESSAGE: cargo update 
##[endgroup]
Starting download for Cargo-lock
##[error]Unable to find any artifacts for the associated workflow

@weihanglo
Copy link
Member

Thanks people for helping update the submodule!

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b13a71a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [0.5%, 5.3%] 16
Regressions ❌
(secondary)
3.2% [1.5%, 6.0%] 38
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [0.5%, 5.3%] 16

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.88s -> 672.066s (-0.12%)
Artifact size: 315.73 MiB -> 315.70 MiB (-0.01%)

@Muscraft Muscraft deleted the update-cargo branch March 26, 2024 15:46
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Mar 31, 2024
spikespaz pushed a commit to spikespaz/dotwalk-rs that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants