ThinBox: move WithHeader to submodule #123705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Requested by @oli-obk. I don't have strong opinion either way. r? oli-obk
oli-obk
reviewed
Apr 11, 2024
| } | ||
| } | ||
| } // mod with_header |
There was a problem hiding this comment.
hmm... maybe use a separate file after all 😅 sorry
oli-obk
added
S-waiting-on-author
|
@stepancheg any updates on this? thanks |
|
☔ The latest upstream changes (presumably #126736) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #123254.
This PR just moves
WithHeaderandWithOpaqueHeaderto submodule marks everything needed outside aspub(super), and adds imports in submodule. Nothing more.Suggested by @oli-obk. I don't have strong opinion either way.
r? oli-obk