Skip to content

add more tests #124435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 28, 2024
Merged

add more tests #124435

merged 8 commits into from
Apr 28, 2024

Conversation

matthiaskrgr
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2024
@jieyouxu
Copy link
Member

Thanks! r=me after CI is green

@matthiaskrgr
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Apr 27, 2024

📌 Commit f7b9861 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#124435 - matthiaskrgr:tests, r=jieyouxu
625f5d4 
add more tests

r? `@jieyouxu`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2024
@bors
Auto merge of rust-lang#124442 - matthiaskrgr:rollup-eims8ym, r=matth…
919c89b 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124370 (Fix substitution parts having a shifted underline in some cases)
 - rust-lang#124405 (miri core/alloc tests: do not test a 2nd target)
 - rust-lang#124425 (Do not ICE on invalid consts when walking mono-reachable blocks)
 - rust-lang#124435 (add more tests)
 - rust-lang#124437 (doc: Make the `mod.rs` in the comment point to the correct location)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member Author

something failed on win
@bors r-
#124442 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 27, 2024
@matthiaskrgr
add test for ICE: tcx.resolutions(()) is not supported for local crat…
c968b8b 
…e -Zunpretty=mir on invalid module path with staged_ap

Fixes rust-lang#108697
@matthiaskrgr
add test for rust-lang#109812
c32e2fe
@matthiaskrgr
add test for Inconsistent rustc_transmute::is_transmutable(...) resul…
012f9e2 
…t, got Yes

Fixes rust-lang#110969
@matthiaskrgr
add test for ICE failed to resolve instance for <[f32; 2] as CrossPro…
f483971 
…duct

Fixes rust-lang#111667
@matthiaskrgr
add test for const generic ty's with lifetimes cause opaque types to ICE
bb47695 
Fixes rust-lang#111911
@matthiaskrgr
add test for ice future has no bound vars.
27338f2 
Fixes rust-lang#112347
@matthiaskrgr
add test for ice expected-type-of-closure-body-to-be-a-closure-or-cor…
f536a06 
…outine-ice-113776.stderr

Fixes rust-lang#113776
@matthiaskrgr
try to fix tests on windows where the "file not found" error is diffe…
a15996c 
…rent from linux
@matthiaskrgr
Copy link
Member Author

"file not found" is different on windows and linux, need to norm test output
@bors r=jieyouxu rollup=iffy

@bors
Copy link
Collaborator

bors commented Apr 28, 2024

📌 Commit a15996c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 28, 2024
@bors
Copy link
Collaborator

bors commented Apr 28, 2024

⌛ Testing commit a15996c with merge ba00750...

@bors
Copy link
Collaborator

bors commented Apr 28, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing ba00750 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2024
@bors bors merged commit ba00750 into rust-lang:master Apr 28, 2024
@rustbot rustbot added this to the 1.80.0 milestone Apr 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ba00750): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-2.3%, -2.1%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.319s -> 673.808s (-0.08%)
Artifact size: 315.93 MiB -> 315.93 MiB (-0.00%)

@matthiaskrgr matthiaskrgr deleted the tests branch January 25, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @jieyouxu @bors @rust-timer @rustbot