Skip to content

Move tests #125256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Move tests #125256

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/tools/tidy/src/issues.txt
Original file line number Diff line number Diff line change
@@ -853,6 +853,8 @@ ui/coroutine/issue-87142.rs
ui/coroutine/issue-88653.rs
ui/coroutine/issue-91477.rs
ui/coroutine/issue-93161.rs
ui/cross-crate/issue-38875/auxiliary/issue-38875-b.rs
ui/cross-crate/issue-38875/issue-38875.rs
Comment on lines +856 to +857
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue was named "constant evaluation error" points to nothing when crossing the crate boundary, the solution PR was implement lazy-loading of crate's sources, could you rename this for that? Perhaps the root one should be

  • tests/ui/cross-crate/lazy-load-externs/const-issue-38875.rs

ui/cross-crate/issue-64872/issue-64872.rs
ui/cycle-trait/issue-12511.rs
ui/debuginfo/issue-105386-debuginfo-ub.rs
@@ -1137,6 +1139,9 @@ ui/generics/issue-32498.rs
ui/generics/issue-333.rs
ui/generics/issue-59508-1.rs
ui/generics/issue-59508.rs
ui/generics/issue-5997-outer-generic-parameter/issue-5997-enum.rs
ui/generics/issue-5997-outer-generic-parameter/issue-5997-struct.rs
ui/generics/issue-5997-outer-generic-parameter/issue-5997.rs
Comment on lines +1142 to +1144
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same request.

ui/generics/issue-61631-default-type-param-can-reference-self-in-trait.rs
ui/generics/issue-61631-default-type-param-cannot-reference-self.rs
ui/generics/issue-65285-incorrect-explicit-lifetime-name-needed.rs
@@ -1912,8 +1917,6 @@ ui/issues/issue-24533.rs
ui/issues/issue-24589.rs
ui/issues/issue-2463.rs
ui/issues/issue-24682.rs
ui/issues/issue-24687-embed-debuginfo/auxiliary/issue-24687-lib.rs
ui/issues/issue-24687-embed-debuginfo/auxiliary/issue-24687-mbcs-in-comments.rs
ui/issues/issue-2470-bounds-check-overflow.rs
ui/issues/issue-2472.rs
ui/issues/issue-24779.rs
@@ -2168,8 +2171,6 @@ ui/issues/issue-36379.rs
ui/issues/issue-36400.rs
ui/issues/issue-36474.rs
ui/issues/issue-3656.rs
ui/issues/issue-3668-non-constant-value-in-constant/issue-3668-2.rs
ui/issues/issue-3668-non-constant-value-in-constant/issue-3668.rs
ui/issues/issue-36744-bitcast-args-if-needed.rs
ui/issues/issue-36786-resolve-call.rs
ui/issues/issue-3680.rs
@@ -2184,7 +2185,6 @@ ui/issues/issue-3702.rs
ui/issues/issue-37051.rs
ui/issues/issue-37109.rs
ui/issues/issue-37131.rs
ui/issues/issue-37311-type-length-limit/issue-37311.rs
ui/issues/issue-37510.rs
ui/issues/issue-3753.rs
ui/issues/issue-37534.rs
@@ -2209,8 +2209,6 @@ ui/issues/issue-38727.rs
ui/issues/issue-3874.rs
ui/issues/issue-38763.rs
ui/issues/issue-38857.rs
ui/issues/issue-38875/auxiliary/issue-38875-b.rs
ui/issues/issue-38875/issue-38875.rs
ui/issues/issue-3888-2.rs
ui/issues/issue-38919.rs
ui/issues/issue-38942.rs
@@ -2510,9 +2508,6 @@ ui/issues/issue-59494.rs
ui/issues/issue-5950.rs
ui/issues/issue-59756.rs
ui/issues/issue-5988.rs
ui/issues/issue-5997-outer-generic-parameter/issue-5997-enum.rs
ui/issues/issue-5997-outer-generic-parameter/issue-5997-struct.rs
ui/issues/issue-5997-outer-generic-parameter/issue-5997.rs
ui/issues/issue-60218.rs
ui/issues/issue-60622.rs
ui/issues/issue-60989.rs
@@ -3030,6 +3025,8 @@ ui/modules/issue-13872.rs
ui/modules/issue-1920-1.rs
ui/modules/issue-1920-2.rs
ui/modules/issue-1920-3.rs
ui/modules/issue-24687-embed-debuginfo/auxiliary/issue-24687-lib.rs
ui/modules/issue-24687-embed-debuginfo/auxiliary/issue-24687-mbcs-in-comments.rs
ui/modules/issue-56411-aux.rs
ui/modules/issue-56411.rs
ui/moves/issue-22536-copy-mustnt-zero.rs
@@ -3618,6 +3615,7 @@ ui/recursion/issue-83150.rs
ui/recursion/issue-86784.rs
ui/recursion/issue-95134.rs
ui/recursion_limit/issue-105700.rs
ui/recursion_limit/issue-37311-type-length-limit/issue-37311.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please instead rename this and the associated .stderr files to

  • tests/ui/recursion_limit/type-length-limit-issue-37311.rs
  • tests/ui/recursion_limit/type-length-limit-issue-37311.stderr
  • tests/ui/recursion_limit/type-length-limit-issue-37311.polonius.stderr

My reasoning is that there doesn't seem to be much merit in nesting these inside a folder that has the same name, and that this would allow eliminating these entries from this list.

ui/recursion_limit/issue-40003.rs
ui/regions/issue-101280.rs
ui/regions/issue-102374.rs
@@ -3850,6 +3848,8 @@ ui/static/issue-18118.rs
ui/static/issue-24446.rs
ui/static/issue-24843.rs
ui/static/issue-34194.rs
ui/static/issue-3668-non-constant-value-in-constant/issue-3668-2.rs
ui/static/issue-3668-non-constant-value-in-constant/issue-3668.rs
Comment on lines +3851 to +3852
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same request but

  • tests/ui/static/non-constant-value-in-constant-issue-3668.rs
  • tests/ui/static/non-constant-value-in-constant-issue-3668-2.rs

and so on.

ui/static/issue-5216.rs
ui/statics/issue-14227.rs
ui/statics/issue-15261.rs
2 changes: 1 addition & 1 deletion src/tools/tidy/src/ui_tests.rs
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ use std::path::{Path, PathBuf};
const ENTRY_LIMIT: usize = 900;
// FIXME: The following limits should be reduced eventually.

const ISSUES_ENTRY_LIMIT: usize = 1676;
const ISSUES_ENTRY_LIMIT: usize = 1669;
const ROOT_ENTRY_LIMIT: usize = 859;

const EXPECTED_TEST_FILE_EXTENSIONS: &[&str] = &[
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ note: `<T as Foo>::recurse` defined here
|
LL | fn recurse(&self) {
| ^^^^^^^^^^^^^^^^^
= note: the full type name has been written to '$TEST_BUILD_DIR/issues/issue-37311-type-length-limit/issue-37311/issue-37311.long-type.txt'
= note: the full type name has been written to '$TEST_BUILD_DIR/recursion_limit/issue-37311-type-length-limit/issue-37311/issue-37311.long-type.txt'

error: aborting due to 1 previous error