Add an option to not run rustdoc blocks #12777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| runtest(test, cratename, libs, should_fail); | ||
| if !no_run { | ||
| runtest(test, cratename, libs, should_fail); | ||
| } |
There was a problem hiding this comment.
Doesn't this both not run the test and not compile it? I thought no_run was to only not run, but still compile?
There was a problem hiding this comment.
Oops, I misread the way this worked :/
|
I also just remembered that I have done this in the past via: It's probably better to have an official solution for this though. |
| You can specify that the code block should be compiled but not run with the | ||
| `no_run` directive. | ||
|
|
||
| ~~~ |
There was a problem hiding this comment.
This will have to change after #12747 lands: https://github.com/mozilla/rust/pull/12747/files#diff-1549ab8fe181dacd0922ab15063fd424R108
This is useful for code that would be expensive to run or has some kind of external dependency (e.g. a database or server).
|
@alexcrichton updated |
bors
added a commit
that referenced
this pull request
Mar 9, 2014
This is useful for code that would be expensive to run or has some kind of external dependency (e.g. a database or server).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 17, 2024
… r=Alexendoo fix: merge multiple suggestions into a single multi-span suggestion in `needless_late_init` See rust-lang/rust-analyzer#17163 (comment). Currently, the fix for `needless_late_init` would modify multiple parts in the file. However, these modifications are exported as separate suggestions instead of a unified 'multi-part suggestion'. Consequently, rust-analyzer is unable to perform the fix correctly when applying suggestions automatically, as only one suggestion is processed at a time. This PR addresses this issue by merge all modifications into a single multi-part suggestion. changelog: [`needless_late_init`]: merge multiple fixes into a single multi-span fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for code that would be expensive to run or has some kind
of external dependency (e.g. a database or server).