Skip to content

std: Rename Chan/Port types and constructor #12815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2014
Merged

std: Rename Chan/Port types and constructor #12815

merged 1 commit into from
Mar 13, 2014

Conversation

alexcrichton
Copy link
Member

  • Chan => Sender
  • Port => Receiver
  • Chan::new() => channel()
  • constructor returns (Sender, Receiver) instead of (Receiver, Sender)
  • local variables named port renamed to rx
  • local variables named chan renamed to tx

Closes #11765

@brson
Copy link
Contributor

brson commented Mar 10, 2014

Epic renaming.

@alexcrichton
std: Rename Chan/Port types and constructor
7858065 
* Chan<T> => Sender<T>
* Port<T> => Receiver<T>
* Chan::new() => channel()
* constructor returns (Sender, Receiver) instead of (Receiver, Sender)
* local variables named `port` renamed to `rx`
* local variables named `chan` renamed to `tx`

Closes rust-lang#11765
bors added a commit that referenced this pull request Mar 13, 2014
@bors
auto merge of #12815 : alexcrichton/rust/chan-rename, r=brson
b4d3243 
* Chan<T> => Sender<T>
* Port<T> => Receiver<T>
* Chan::new() => channel()
* constructor returns (Sender, Receiver) instead of (Receiver, Sender)
* local variables named `port` renamed to `rx`
* local variables named `chan` renamed to `tx`

Closes #11765
@bors bors closed this Mar 13, 2014
@bors bors merged commit 7858065 into rust-lang:master Mar 13, 2014
@alexcrichton alexcrichton deleted the chan-rename branch March 13, 2014 22:21
chris-morgan added a commit to chris-morgan/rust-http that referenced this pull request Mar 13, 2014
@chris-morgan
Rename things from std::comm (rust-lang/rust#12815).
076e13a
tedhorst added a commit to tedhorst/rust that referenced this pull request Mar 14, 2014
@tedhorst
fix a test that was missed in the chan/port renaming (PR rust-lang#12815
e9bd121 
)
@tedhorst tedhorst mentioned this pull request Mar 14, 2014
Merged
bors added a commit that referenced this pull request Mar 14, 2014
@bors
auto merge of #12880 : tedhorst/rust/master, r=alexcrichton
e99d523 
Fix a test that was missed in the chan/port renaming (PR #12815).  This was missed because it is skipped on linux and windows, and the mac bots were moving at the time the PR landed.
@edwardw edwardw mentioned this pull request Mar 16, 2014
Merged
bors added a commit that referenced this pull request Mar 16, 2014
@bors
auto merge of #12933 : edwardw/rust/fallout, r=huonw
7647849 
The same test was missed in chan/port renaming PR #12815 and was fixed in #12880:

> This was missed because it is skipped on linux and windows, and the mac bots were moving at the time the PR landed.

It seems the same happened to the liblog PR.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 13, 2024
@bors
Auto merge of rust-lang#12815 - GuillaumeGomez:add-needless_character…
61d3e14 
…_iteration, r=xFrednet

Add `needless_character_iteration` lint

Fixes rust-lang#4817.

r? `@xFrednet`

changelog: Add `needless_character_iteration` lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename channel types and constructor
3 participants
@alexcrichton @brson @bors