rustuv: Fix a use-after-free in TTY failure #12823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a TTY fails to get initialized, it still needs to have uv_close invoked on it. This fixes the problem by constructing the TtyWatcher struct before the call to uv_tty_init. The struct has a destructor on it which will close the handle properly. Closes rust-lang#12666
bors
added a commit
that referenced
this pull request
Mar 13, 2014
If a TTY fails to get initialized, it still needs to have uv_close invoked on it. This fixes the problem by constructing the TtyWatcher struct before the call to uv_tty_init. The struct has a destructor on it which will close the handle properly. Closes #12666
fasterthanlime
pushed a commit
to fasterthanlime/rust
that referenced
this pull request
Jul 24, 2022
When the cursor is in a match arm, but before the fat arrow (=>) token, don't add braces when autocompleting "if". fixes rust-lang#12823
fasterthanlime
pushed a commit
to fasterthanlime/rust
that referenced
this pull request
Jul 24, 2022
…match-guard, r=Veykril fix: Don't add braces to 'if' completion in match guard position fixes rust-lang#12823 Is this what you were thinking of here, `@Veykril` ? I haven't done any work on completions before, so I could definitely be misunderstanding the issue.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2024
…s, r=y21 Suppress `iter_on_empty_collections` if the iterator's concrete type is relied upon changelog: fixed rust-lang#12807
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 4, 2025
…enton Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4b to detect a UAF in `libuv` (see rust-lang#12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes rust-lang#144878 (by removing the test). r? libs
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 5, 2025
…enton Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4b to detect a UAF in `libuv` (see rust-lang#12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes rust-lang#144878 (by removing the test). r? libs
rust-timer
added a commit
that referenced
this pull request
Aug 5, 2025
Rollup merge of #144894 - jieyouxu:chop-thread-cnt, r=ChrisDenton Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4b to detect a UAF in `libuv` (see #12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes #144878 (by removing the test). r? libs
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 7, 2025
Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4bd3fa0abe1000662014b3e3ea1420728f5 to detect a UAF in `libuv` (see rust-lang/rust#12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes rust-lang/rust#144878 (by removing the test). r? libs
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Aug 11, 2025
Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4b to detect a UAF in `libuv` (see rust-lang/rust#12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes rust-lang/rust#144878 (by removing the test). r? libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a TTY fails to get initialized, it still needs to have uv_close invoked on
it. This fixes the problem by constructing the TtyWatcher struct before the call
to uv_tty_init. The struct has a destructor on it which will close the handle
properly.
Closes #12666