Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ChrisDenton and others added 6 commits September 9, 2024 12:05
…crum

Use a small runner for msvc-ext2 job

Hopefully this should eliminate the errors from this job. The only question is how long it takes.

try-job: x86_64-msvc-ext2
const: don't ICE when encountering a mutable ref to immutable memory

Turns out that this can actually happen -- thanks to `@matthiaskrgr` for producing a testcase. :)

Fixes rust-lang#130392
…r-errors

tests: more ice tests

r? `@jieyouxu`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 15, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Collaborator

bors commented Sep 15, 2024

📌 Commit 0406f12 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2024
@bors
Copy link
Collaborator

bors commented Sep 15, 2024

⌛ Testing commit 0406f12 with merge d696a27...

@bors
Copy link
Collaborator

bors commented Sep 16, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d696a27 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2024
@bors bors merged commit d696a27 into rust-lang:master Sep 16, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 16, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#130151 Use a small runner for msvc-ext2 job 9a6ed85d44659ec8b6ba7c3643b25a78e979ba99 (link)
#130394 const: don't ICE when encountering a mutable ref to immutab… 6250dfdfa0a8bd3dcc431cd519e409779a045fa2 (link)
#130409 tests: more ice tests cfd715ae6f2aede7c7e9045ce3dcc0cd8c587c9b (link)

previous master: 04a318787b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d696a27): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.8%, secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-1.8%, -1.8%] 1
Improvements ✅
(secondary)
-2.9% [-4.2%, -1.8%] 3
All ❌✅ (primary) -1.8% [-1.8%, -1.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 758.794s -> 759.759s (0.13%)
Artifact size: 341.06 MiB -> 341.11 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-xhsu9oq branch January 25, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants