Derive TotalEq for std::intrinsics::TypeId #13154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashMap and HashSet require keys to implement TotalEq. This makes it possible to use TypeId as a HashMap key again.
bors
added a commit
that referenced
this pull request
Mar 28, 2014
HashMap and HashSet require keys to implement TotalEq. This makes it possible to use TypeId as a HashMap key again. Question for reviewers: assuming we want to support `HashMap<TypeId, whatever>`, would it make sense to add a relevant test? If so, should it go to libcollections or libstd?
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Sep 6, 2022
Drop the expander borrow in all control flow paths The change in rust-lang/rust-analyzer#13123 actually re-uses the RefMut borrow instead of dropping it so we need to drop it manually where required. Fixes rust-lang/rust-analyzer#13153
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 25, 2024
Temporarily remove myself from reviewer rotation I'm going to focus on the project goal and my own contributions, this + medical stuff leaves me not enough time to review. I'll still review any performance related PR, and you can still request from me a benchmark for a PR, and will finish the PRs that I'm still assign to. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashMap and HashSet require keys to implement TotalEq. This makes it possible to use TypeId as a HashMap key again.
Question for reviewers: assuming we want to support
HashMap<TypeId, whatever>, would it make sense to add a relevant test? If so, should it go to libcollections or libstd?