Skip to content

Prevent overflowing enum cast from ICEing #131909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

Prevent overflowing enum cast from ICEing #131909

merged 1 commit into from
Oct 24, 2024

Conversation

clubby789
Copy link
Contributor

@clubby789 clubby789 commented Oct 18, 2024 •
edited
Loading

Fixes #131902

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2024
jieyouxu
jieyouxu reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delaying a bug all the way in THIR seems a bit strange, but I also don't know what's the proper handling for this.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 19, 2024 •
edited
Loading

r? types

@rust-lang rust-lang deleted a comment from rustbot Oct 19, 2024
@rustbot rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Oct 19, 2024
@rustbot rustbot assigned jackh726 and unassigned jieyouxu Oct 19, 2024
@jieyouxu jieyouxu removed the T-types Relevant to the types team, which will review and decide on the PR/issue. label Oct 19, 2024
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 24, 2024

📌 Commit ab4222a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2024
@Zalathar Zalathar mentioned this pull request Oct 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2024
@bors
Auto merge of rust-lang#132094 - Zalathar:rollup-5r1ppqt, r=Zalathar
55b7f8e 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#130225 (Rename Receiver -> LegacyReceiver)
 - rust-lang#131169 (Fix `target_vendor` in QNX Neutrino targets)
 - rust-lang#131623 (misc cleanups)
 - rust-lang#131756 (Deeply normalize `TypeTrace` when reporting type error in new solver)
 - rust-lang#131898 (minor `*dyn` cast cleanup)
 - rust-lang#131909 (Prevent overflowing enum cast from ICEing)
 - rust-lang#131930 (Don't allow test revisions that conflict with built in cfgs)
 - rust-lang#131956 (coverage: Pass coverage mappings to LLVM as separate structs)
 - rust-lang#132076 (HashStable for rustc_feature::Features: stop hashing compile-time constant)
 - rust-lang#132088 (Print safety correctly in extern static items)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b02d64 into rust-lang:master Oct 24, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2024
@rust-timer
Unrolled build for rust-lang#131909
f23700a 
Rollup merge of rust-lang#131909 - clubby789:enum-overflow-cast, r=compiler-errors

Prevent overflowing enum cast from ICEing

Fixes rust-lang#131902
@jieyouxu jieyouxu mentioned this pull request Dec 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.

Panic in rustc when casting invalid enum discriminant
6 participants
@clubby789 @rustbot @jieyouxu @compiler-errors @bors @jackh726