Skip to content

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Nov 30, 2024

Resolves an internal bootstrap FIXME.

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 30, 2024
@Kobzol
Copy link
Member

Kobzol commented Nov 30, 2024

Nice cleanup! You can r=me after PR CI is green.

@Kobzol
Copy link
Member

Kobzol commented Nov 30, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 30, 2024

📌 Commit fd90198 has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 30, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2024
RalfJung added a commit to RalfJung/rust that referenced this pull request Nov 30, 2024
replace hard coded error id with `ErrorKind::DirectoryNotEmpty`

Resolves an internal bootstrap FIXME.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131698 (use stores of the correct size to set discriminants)
 - rust-lang#133571 (Mark visionOS as supporting `std`)
 - rust-lang#133655 (Eliminate print_expr_maybe_paren function from pretty printers)
 - rust-lang#133667 (Remove unused code)
 - rust-lang#133670 (bump hashbrown version)
 - rust-lang#133673 (replace hard coded error id with `ErrorKind::DirectoryNotEmpty`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bdb44d0 into rust-lang:master Nov 30, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
Rollup merge of rust-lang#133673 - onur-ozkan:windows-fixme, r=Kobzol

replace hard coded error id with `ErrorKind::DirectoryNotEmpty`

Resolves an internal bootstrap FIXME.
@rustbot rustbot added this to the 1.85.0 milestone Nov 30, 2024
@onur-ozkan onur-ozkan deleted the windows-fixme branch December 2, 2024 05:58
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131698 (use stores of the correct size to set discriminants)
 - rust-lang#133571 (Mark visionOS as supporting `std`)
 - rust-lang#133655 (Eliminate print_expr_maybe_paren function from pretty printers)
 - rust-lang#133667 (Remove unused code)
 - rust-lang#133670 (bump hashbrown version)
 - rust-lang#133673 (replace hard coded error id with `ErrorKind::DirectoryNotEmpty`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants