Update LLVM to 19.1.5 #133799

dianqk · 2024-12-03T13:34:21Z

Fixes #133276. Fixes #133203.

r? nikic or wg-llvm

rustbot · 2024-12-03T13:34:30Z

⚠️ Warning ⚠️

These commits modify submodules.

dianqk · 2024-12-03T13:37:59Z

I'm considering adding test cases for #133281 base on #131526 (comment) in a future PR.

nikic · 2024-12-03T13:41:45Z

@bors r+ rollup=never

bors · 2024-12-03T13:41:48Z

📌 Commit 605306e has been approved by nikic

It is now in the queue for this repository.

bors · 2024-12-03T22:18:00Z

⌛ Testing commit 605306e with merge dfb2c3a...

Update LLVM to 19.1.5 Fixes rust-lang#133276. Fixes rust-lang#133203. r? nikic or wg-llvm

rust-log-analyzer · 2024-12-04T00:45:21Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 32.097
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\symbols.o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-96d0305fb1a0ac21.rustc_main.3d1443240c21f921-cgu.0.rcgu.o" "-Wl,-Bdynamic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_driver-9266893fdc6ace7c.dll" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\std-85e8e1afc0a1e2c0.dll" "-Wl,-Bstatic" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-d77c9d76f065957b.rlib" "-Wl,-Bdynamic" "-lpsapi" "-lshell32" "-lole32" "-luuid" "-ladvapi32" "-lws2_32" "-lntdll" "-lkernel32" "-ladvapi32" "-lole32" "-loleaut32" "-ladvapi32" "-lcfgmgr32" "-lgdi32" "-lkernel32" "-lmsimg32" "-lopengl32" "-luser32" "-lwinspool" "-lbcrypt" "-ladvapi32" "-lkernel32" "-lkernel32" "-ladvapi32" "-lntdll" "-luserenv" "-lws2_32" "-ldbghelp" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustc2mKPHX\\wofutil.dll_imports_indirect.lib" "-lgcc_s" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmingwex" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\stacker-d3f5f2020a9db92d\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\psm-209b3c2f591fdc56\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\blake3-a0d1954ccec93ff8\\out" "-L" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\build\\rustc_llvm-9c1d12dc9076cada\\out" "-L" "C:/a/rust/rust/build/i686-pc-windows-gnu/llvm/lib" "-L" "C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0" "-o" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1-rustc\\i686-pc-windows-gnu\\release\\deps\\rustc_main-96d0305fb1a0ac21.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-nodefaultlibs" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage1\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: C:/a/rust/rust/mingw32/bin/../lib/gcc/i686-w64-mingw32/14.1.0/../../../../i686-w64-mingw32/bin/ld.exe: cannot open output file C:\a\rust\rust\build\i686-pc-windows-gnu\stage1-rustc\i686-pc-windows-gnu\release\deps\rustc_main-96d0305fb1a0ac21.exe: Invalid argument␍
          collect2.exe: error: ld returned 1 exit status

[RUSTC-TIMING] rustc_main test:false 4.402
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:34:21

bors · 2024-12-04T00:46:02Z

💔 Test failed - checks-actions

dianqk · 2024-12-04T01:22:14Z

@bors retry

bors · 2024-12-04T10:33:36Z

⌛ Testing commit 605306e with merge 96e51d9...

bors · 2024-12-04T13:24:05Z

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 96e51d9 to master...

rust-timer · 2024-12-04T15:14:08Z

Finished benchmarking commit (96e51d9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

Results (secondary 1.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.8%	[1.8%, 1.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 766.894s -> 767.015s (0.02%)
Artifact size: 330.84 MiB -> 330.85 MiB (0.00%)

apiraino · 2024-12-05T15:17:04Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

[beta] backports * Update LLVM to 19.1.5 rust-lang#133799 r? cuviper

Update LLVM to 19.1.5

605306e

rustbot assigned nikic Dec 3, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024

Auto merge of rust-lang#133799 - DianQK:llvm/19.1.5, r=nikic

dfb2c3a

Update LLVM to 19.1.5 Fixes rust-lang#133276. Fixes rust-lang#133203. r? nikic or wg-llvm

bors mentioned this pull request Dec 3, 2024

Rollup of 7 pull requests #133818

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2024

matthiaskrgr added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Dec 4, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2024

bors merged commit 96e51d9 into rust-lang:master Dec 4, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Dec 4, 2024

dianqk deleted the llvm/19.1.5 branch December 5, 2024 00:02

dianqk added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 5, 2024

cuviper mentioned this pull request Dec 5, 2024

[beta] backports #133933

Merged

cuviper modified the milestones: 1.85.0, 1.84.0 Dec 5, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 5, 2024

ChrisDenton added CI-spurious-fail-mingw CI spurious failure: target env mingw and removed CI-spurious-fail-msvc CI spurious failure: target env msvc labels Dec 6, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 7, 2024

Auto merge of rust-lang#133933 - cuviper:beta-next, r=cuviper

202008a

[beta] backports * Update LLVM to 19.1.5 rust-lang#133799 r? cuviper

dianqk mentioned this pull request Dec 14, 2024

SIGSEGV/SIGILL while building rustc itself in x86_64 apple CI jobs #134220

Open

workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update LLVM to 19.1.5 #133799

Update LLVM to 19.1.5 #133799

Uh oh!

dianqk commented Dec 3, 2024

Uh oh!

rustbot commented Dec 3, 2024

Uh oh!

dianqk commented Dec 3, 2024

Uh oh!

nikic commented Dec 3, 2024

Uh oh!

bors commented Dec 3, 2024

Uh oh!

bors commented Dec 3, 2024

Uh oh!

rust-log-analyzer commented Dec 4, 2024

Uh oh!

bors commented Dec 4, 2024

Uh oh!

dianqk commented Dec 4, 2024

Uh oh!

bors commented Dec 4, 2024

Uh oh!

bors commented Dec 4, 2024

Uh oh!

Uh oh!

rust-timer commented Dec 4, 2024

Uh oh!

apiraino commented Dec 5, 2024

Uh oh!

Uh oh!

Update LLVM to 19.1.5 #133799

Update LLVM to 19.1.5 #133799

Uh oh!

Conversation

dianqk commented Dec 3, 2024

Uh oh!

rustbot commented Dec 3, 2024

Uh oh!

dianqk commented Dec 3, 2024

Uh oh!

nikic commented Dec 3, 2024

Uh oh!

bors commented Dec 3, 2024

Uh oh!

bors commented Dec 3, 2024

Uh oh!

rust-log-analyzer commented Dec 4, 2024

Uh oh!

bors commented Dec 4, 2024

Uh oh!

dianqk commented Dec 4, 2024

Uh oh!

bors commented Dec 4, 2024

Uh oh!

bors commented Dec 4, 2024

Uh oh!

Uh oh!

rust-timer commented Dec 4, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

apiraino commented Dec 5, 2024

Uh oh!

Uh oh!