-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Some random compiler nits #135708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Some random compiler nits #135708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll trade you a revert PR review for it :) |
lqd
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors r=lqd |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#135641 ([rustdoc] Replace module list items `ul`/`li` with `dl`/`dd`/`dt` elements) - rust-lang#135703 (Disallow `A { .. }` if `A` has no fields) - rust-lang#135705 (Consolidate ad-hoc MIR lints into real pass-manager-based MIR lints) - rust-lang#135708 (Some random compiler nits) Failed merges: - rust-lang#135685 (Remove unused `item-row` CSS class) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2025
Rollup merge of rust-lang#135708 - compiler-errors:compiler-nits, r=lqd Some random compiler nits The only "observable" change here is using `par_body_owners` for coroutine witnesses/coroutine obligation checking. r? lqd (or reassign, you just seem to like to approve prs :3 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only "observable" change here is using
par_body_owners
for coroutine witnesses/coroutine obligation checking.r? lqd (or reassign, you just seem to like to approve prs :3 )