Skip to content

Some random compiler nits #135708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Some random compiler nits #135708

merged 3 commits into from
Jan 19, 2025

Conversation

compiler-errors
Copy link
Member

The only "observable" change here is using par_body_owners for coroutine witnesses/coroutine obligation checking.

r? lqd (or reassign, you just seem to like to approve prs :3 )

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2025
@lqd
Copy link
Member

lqd commented Jan 18, 2025

I'll trade you a revert PR review for it :)

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

r=me

when CI is green

@compiler-errors
Copy link
Member Author

@bors r=lqd

@bors
Copy link
Collaborator

bors commented Jan 18, 2025

📌 Commit 0e98d9a has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#135641 ([rustdoc] Replace module list items `ul`/`li` with `dl`/`dd`/`dt` elements)
 - rust-lang#135703 (Disallow `A { .. }` if `A` has no fields)
 - rust-lang#135705 (Consolidate ad-hoc MIR lints into real pass-manager-based MIR lints)
 - rust-lang#135708 (Some random compiler nits)

Failed merges:

 - rust-lang#135685 (Remove unused `item-row` CSS class)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c87dd96 into rust-lang:master Jan 19, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2025
Rollup merge of rust-lang#135708 - compiler-errors:compiler-nits, r=lqd

Some random compiler nits

The only "observable" change here is using `par_body_owners` for coroutine witnesses/coroutine obligation checking.

r? lqd (or reassign, you just seem to like to approve prs :3 )
@rustbot rustbot added this to the 1.86.0 milestone Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants