Skip to content

Conversation

RalfJung
Copy link
Member

r? @ghost

The Miri Cronjob Bot and others added 30 commits December 27, 2024 05:16
FD handling: avoid unnecessary dynamic downcasts
    * Introduce UnblockKind enum to represent operation outcomes
    * Consolidate unblock/timeout methods into single callback interface
    * Update thread blocking system to use new callback mechanism
    * Refactor mutex and condvar implementations for new callback pattern

Signed-off-by: shamb0 <[email protected]>
triagebot: enable merge conflict notification
…i-concurrency

Concurrency: Generalize UnblockCallback to MachineCallback
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2025
@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jan 19, 2025

📌 Commit 49375c4 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2025
@bors
Copy link
Collaborator

bors commented Jan 19, 2025

⌛ Testing commit 49375c4 with merge 9a1d156...

@bors
Copy link
Collaborator

bors commented Jan 19, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 9a1d156 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 19, 2025
@bors bors merged commit 9a1d156 into rust-lang:master Jan 19, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 19, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9a1d156): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.0%, secondary 3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [2.3%, 4.4%] 2
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.299s -> 766.411s (0.15%)
Artifact size: 325.96 MiB -> 325.99 MiB (0.01%)

@RalfJung RalfJung deleted the miri-sync branch January 20, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants