[rustdoc] Improve display of prev/next scraped examples buttons #136870
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
notriddle
reviewed
Feb 12, 2025
Comment on lines
+63
to
+64
| const next = createScrapeButton(buttonHolder, "next", ">"); | ||
| const prev = createScrapeButton(buttonHolder, "prev", "<"); |
There was a problem hiding this comment.
In the past, we've tried to move away from using punctuation as icons, because it looks confusingly like syntax. We could use the same unicode icons as the expand buttons, or we could use SVG. #136950
Suggested change
| const next = createScrapeButton(buttonHolder, "next", ">"); | |
| const prev = createScrapeButton(buttonHolder, "prev", "<"); | |
| const next = createScrapeButton(buttonHolder, "next", "→"); | |
| const prev = createScrapeButton(buttonHolder, "prev", "←"); |
|
Closing in favor of #136950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it looks like this:
Which is... not great. With this PR, it now looks like this:
It switched to the plain
<and>characters and made them a bit bigger so they match other buttons size.r? @notriddle