Skip to content

Subtree update of rust-analyzer #137523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Feb 24, 2025
Merged

Subtree update of rust-analyzer #137523

merged 45 commits into from
Feb 24, 2025

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 24, 2025

r? @ghost

infiniteregrets and others added 30 commits February 17, 2025 10:36
fix formatting

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
doc: move dev docs to manual

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Revert "pass struct fields to chalk"

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Fix dead link

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Ignore assists with many results if grouping not supported

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
…-url

doc: use fully qualified url for source path

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
it is stable since 1.52

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
fix dead links

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
…-line-anchor

doc: missed the L for the line number

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Update configuration.md

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Update architecture.md

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
internal: Use ubuntu-latest workers for releases

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
…-macro

Use correct working directory for non-workspace proc-macro execution

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
fix typos in snippets

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Update editor_features.md

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
minor: Improve unset `OUT_DIR` error message

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
fix dead link

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Update style.md
lnicola and others added 15 commits February 22, 2025 09:07

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
doc: toc for other editors

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
minor: Switch back to RUST_SRC_PATH

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
fix: Binding wrong associated type when lowering bounds like `T: Trait<Assoc = U>`
When running `cargo codegen` the cwd="rust-analyzer" however when running `cargo test` the cwd="rust-analyzer/xtask" which makes the codegen panic
When running `cargo codegen` the `crates/parser/test_data/generated/runner.rs` file is only updated when some file in `crates/parser/test_data/inline` changes. However this is not sufficient in all cases

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Parser inline test codegen panics and/or does not run

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Remove `limit` crate in favor `usize`

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
minor: sync from downstream
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@lnicola
Copy link
Member Author

lnicola commented Feb 24, 2025

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Feb 24, 2025

📌 Commit 6d9b9c1 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2025
@bors
Copy link
Collaborator

bors commented Feb 24, 2025

⌛ Testing commit 6d9b9c1 with merge 617aad8...

@bors
Copy link
Collaborator

bors commented Feb 24, 2025

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 617aad8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2025
@bors bors merged commit 617aad8 into rust-lang:master Feb 24, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 24, 2025
@lnicola lnicola deleted the sync-from-ra branch February 24, 2025 17:10
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (617aad8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 359.63 MiB -> 359.63 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet