Initial implementation of `core_float_math` #138087

tgross35 · 2025-03-06T06:34:53Z

Since 1, compiler-builtins makes a certain set of math symbols
weakly available on all platforms. This means we can begin exposing some
of the related functions in core, so begin this process here.

It is not possible to provide inherent methods in both core and std
while giving them different stability gates, so standalone functions are
added instead. This provides a way to experiment with the functionality
while unstable; once it is time to stabilize, they can be converted to
inherent.

For f16 and f128, everything is unstable so we can move the inherent
methods.

The following are included to start:

floor
ceil
round
round_ties_even
trunc
fract
mul_add
div_euclid
rem_euclid
powi
sqrt
abs_sub
cbrt

These mirror the set of functions that we have in compiler-builtins
since 1, with the exception of powi that has been there longer.

Details for each of the changes is in the commit messages.

Tracking issue: #137578

try-job: x86_64-mingw-1
try-job: x86_64-mingw-2

Initial implementation of `core_float_math` Since [1], `compiler-builtins` makes a certain set of math symbols weakly available on all platforms. This means we can begin exposing some of the related functions in `core`, so begin this process here. It is not possible to provide inherent methods in both `core` and `std` while giving them different stability gates, so standalone functions are added instead. This provides a way to experiment with the functionality while unstable; once it is time to stabilize, they can be converted to inherent. For `f16` and `f128`, everything is unstable so we can move the inherent methods. The following are included to start: * floor * ceil * round * round_ties_even * trunc * fract * mul_add * div_euclid * rem_euclid * powi * sqrt * abs_sub * cbrt These mirror the set of functions that we have in `compiler-builtins` since [1]. Tracking issue: rust-lang#137578 [1]: rust-lang/compiler-builtins#763 r? `@ghost` try-job: aarch64-gnu try-job: arm-android tru-job: armhf-gnu try-job: test-various try-job: x86_64-apple-1 try-job: aarch64-apple try-job: i686-msvc-1 try-job: x86_64-msvc-ext2

Initial implementation of `core_float_math` Since [1], `compiler-builtins` makes a certain set of math symbols weakly available on all platforms. This means we can begin exposing some of the related functions in `core`, so begin this process here. It is not possible to provide inherent methods in both `core` and `std` while giving them different stability gates, so standalone functions are added instead. This provides a way to experiment with the functionality while unstable; once it is time to stabilize, they can be converted to inherent. For `f16` and `f128`, everything is unstable so we can move the inherent methods. The following are included to start: * floor * ceil * round * round_ties_even * trunc * fract * mul_add * div_euclid * rem_euclid * powi * sqrt * abs_sub * cbrt These mirror the set of functions that we have in `compiler-builtins` since [1]. Tracking issue: rust-lang#137578 [1]: rust-lang/compiler-builtins#763 r? `@ghost` try-job: aarch64-apple try-job: aarch64-gnu try-job: arm-android tru-job: armhf-gnu try-job: dist-various-1 try-job: dist-various-2 try-job: i686-msvc-1 try-job: test-various try-job: x86_64-apple-1 try-job: x86_64-msvc-ext2

Initial implementation of `core_float_math` Since [1], `compiler-builtins` makes a certain set of math symbols weakly available on all platforms. This means we can begin exposing some of the related functions in `core`, so begin this process here. It is not possible to provide inherent methods in both `core` and `std` while giving them different stability gates, so standalone functions are added instead. This provides a way to experiment with the functionality while unstable; once it is time to stabilize, they can be converted to inherent. For `f16` and `f128`, everything is unstable so we can move the inherent methods. The following are included to start: * floor * ceil * round * round_ties_even * trunc * fract * mul_add * div_euclid * rem_euclid * powi * sqrt * abs_sub * cbrt These mirror the set of functions that we have in `compiler-builtins` since [1], with the exception of `powi` that has been there longer. Tracking issue: rust-lang#137578 [1]: rust-lang/compiler-builtins#763 r? `@ghost` try-job: aarch64-apple try-job: aarch64-gnu try-job: arm-android tru-job: armhf-gnu try-job: dist-various-1 try-job: dist-various-2 try-job: i686-msvc-1 try-job: test-various try-job: x86_64-apple-1 try-job: x86_64-msvc-ext2

tgross35 · 2025-03-06T21:35:19Z

test-various passed, the others likely only need tweaks for f128 config.

r? @Amanieu

The previous commit moved all test files from `std` to `core` so git understands the move. Not all functionality is actually testable in `core`, however, so perform move the relevant portions back. Changes from inherent to module methods is also done since this is the form of math operations available in `core` (as `core_float_math`).

tgross35 · 2025-04-29T22:36:29Z

Noticed one remaining artifact of the rebase to fix

@bors r=Amanieu

bors · 2025-04-29T22:36:32Z

📌 Commit 64d47f7 has been approved by Amanieu

It is now in the queue for this repository.

Initial implementation of `core_float_math` Since [1], `compiler-builtins` makes a certain set of math symbols weakly available on all platforms. This means we can begin exposing some of the related functions in `core`, so begin this process here. It is not possible to provide inherent methods in both `core` and `std` while giving them different stability gates, so standalone functions are added instead. This provides a way to experiment with the functionality while unstable; once it is time to stabilize, they can be converted to inherent. For `f16` and `f128`, everything is unstable so we can move the inherent methods. The following are included to start: * floor * ceil * round * round_ties_even * trunc * fract * mul_add * div_euclid * rem_euclid * powi * sqrt * abs_sub * cbrt These mirror the set of functions that we have in `compiler-builtins` since [1], with the exception of `powi` that has been there longer. Details for each of the changes is in the commit messages. Tracking issue: rust-lang#137578 [1]: rust-lang/compiler-builtins#763 try-job: aarch64-apple try-job: aarch64-gnu try-job: arm-android tru-job: armhf-gnu try-job: dist-various-1 try-job: dist-various-2 try-job: i686-msvc-1 try-job: test-various try-job: x86_64-apple-1 try-job: x86_64-msvc-ext2

Rollup of 12 pull requests Successful merges: - rust-lang#136160 (Remove backticks from `ShouldPanic::YesWithMessage`'s `TrFailedMsg`) - rust-lang#138087 (Initial implementation of `core_float_math`) - rust-lang#139059 (uses_power_alignment: wording tweaks) - rust-lang#139192 (mention provenance in the pointer::wrapping_offset docs) - rust-lang#140312 (Improve pretty-printing of braces) - rust-lang#140404 (rm `TypeVistable` impls for `Canonical`) - rust-lang#140437 (enable msa feature for mips in codegen tests) - rust-lang#140438 (Add `rust.debug-assertions-tools` option) - rust-lang#140439 (miri: algebraic intrinsics: bring back float non-determinism) - rust-lang#140445 (Treat ManuallyDrop as ~const Destruct) - rust-lang#140446 (chore: fix some tests) - rust-lang#140448 (Rename `rustc_query_append!` to `rustc_with_all_queries!`) Failed merges: - rust-lang#140456 (Fix test simd/extract-insert-dyn on s390x) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-04-30T08:17:42Z

@bors r- rollup=iffy
#140499 (comment)

beetrees · 2025-04-30T13:53:50Z

AFAICT this test failure is caused by the incorrect FMA implementation in MinGW. Also (pre-existing issue, presumably due to the previously-mentioned bug) all the mul_add tests should use assert_eq!, not assert_approx_eq!, as mul_add is meant to be guaranteed to be correctly rounded. I've opened #140515 to track the MinGW issue.

tgross35 · 2025-04-30T16:03:03Z

It looks like that failure may have happened in the cranelift tests which would explain why it is a new failure. Are existing tests just getting lucky that LLVM happens to const fold the result? I can mark them ignore on MinGW unless there is a better solution.

all the mul_add tests should use assert_eq!, not assert_approx_eq!

Good point, the RHS literals are also not exact. I'll do this as a follow up.

tgross35 · 2025-04-30T22:07:22Z

@bors try

bors · 2025-04-30T22:08:34Z

⌛ Trying commit ecb87fc with merge e208dca82fe04c10cacf0ac308c47659eb114ea4...

Initial implementation of `core_float_math` Since [1], `compiler-builtins` makes a certain set of math symbols weakly available on all platforms. This means we can begin exposing some of the related functions in `core`, so begin this process here. It is not possible to provide inherent methods in both `core` and `std` while giving them different stability gates, so standalone functions are added instead. This provides a way to experiment with the functionality while unstable; once it is time to stabilize, they can be converted to inherent. For `f16` and `f128`, everything is unstable so we can move the inherent methods. The following are included to start: * floor * ceil * round * round_ties_even * trunc * fract * mul_add * div_euclid * rem_euclid * powi * sqrt * abs_sub * cbrt These mirror the set of functions that we have in `compiler-builtins` since [1], with the exception of `powi` that has been there longer. Details for each of the changes is in the commit messages. Tracking issue: rust-lang#137578 [1]: rust-lang/compiler-builtins#763 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2

tgross35 · 2025-04-30T22:44:29Z

Added a skip for the fma tests on mingw for now, the try job is running for that. It sounds like we have a fix for #140515 planned so we should be able to unignore them soon.

At this point there have been a handful of changes from the original review (though nothing fundamental), so I re-requested.

Per [1], MinGW has an incorrect fma implementation. This showed up in tests run with cranelift after adding float math operations to `core`. Presumably we hadn't noticed this when running tests with LLVM because LLVM was constant folding the result away. Rust issue: rust-lang#140515 [1]: https://sourceforge.net/p/mingw-w64/bugs/848/

tgross35 · 2025-05-01T00:06:43Z

Seems like fmaf is also affected.

@bors try

bors · 2025-05-01T00:07:56Z

⌛ Trying commit 15af070 with merge 9838adf...

Initial implementation of `core_float_math` Since [1], `compiler-builtins` makes a certain set of math symbols weakly available on all platforms. This means we can begin exposing some of the related functions in `core`, so begin this process here. It is not possible to provide inherent methods in both `core` and `std` while giving them different stability gates, so standalone functions are added instead. This provides a way to experiment with the functionality while unstable; once it is time to stabilize, they can be converted to inherent. For `f16` and `f128`, everything is unstable so we can move the inherent methods. The following are included to start: * floor * ceil * round * round_ties_even * trunc * fract * mul_add * div_euclid * rem_euclid * powi * sqrt * abs_sub * cbrt These mirror the set of functions that we have in `compiler-builtins` since [1], with the exception of `powi` that has been there longer. Details for each of the changes is in the commit messages. Tracking issue: rust-lang#137578 [1]: rust-lang/compiler-builtins#763 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2

bors · 2025-05-01T02:45:11Z

☀️ Try build successful - checks-actions
Build commit: 9838adf (9838adf28c46b1a0309a0ddb48276aedcb179cde)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 6, 2025

This comment has been minimized.

Sign in to view

tgross35 force-pushed the core-float-math branch from 9cc8ffd to b74488e Compare March 6, 2025 07:21

This comment was marked as outdated.

Sign in to view

tgross35 force-pushed the core-float-math branch from b74488e to 12ad9b8 Compare March 6, 2025 07:45

This comment was marked as outdated.

Sign in to view

tgross35 force-pushed the core-float-math branch from 12ad9b8 to 8d57e5a Compare March 6, 2025 08:08

This comment has been minimized.

Sign in to view

tgross35 force-pushed the core-float-math branch from 8d57e5a to eabddae Compare March 6, 2025 09:13

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

tgross35 force-pushed the core-float-math branch 2 times, most recently from 4375018 to 77794c6 Compare March 6, 2025 21:15

This comment was marked as outdated.

Sign in to view

tgross35 marked this pull request as ready for review March 6, 2025 21:35

rustbot assigned Amanieu Mar 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2025

tgross35 force-pushed the core-float-math branch from 24c932d to 64d47f7 Compare April 29, 2025 21:28

Zalathar mentioned this pull request Apr 30, 2025

Rollup of 12 pull requests #140499

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2025

tgross35 force-pushed the core-float-math branch from ecb87fc to 9489ace Compare April 30, 2025 22:10

tgross35 requested a review from Amanieu April 30, 2025 22:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 30, 2025

This comment has been minimized.

Sign in to view

tgross35 force-pushed the core-float-math branch from 9489ace to 15af070 Compare May 1, 2025 00:04

tgross35 mentioned this pull request May 1, 2025

mul_add on *-pc-windows-gnu returns incorrect results #140515

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation of `core_float_math` #138087

Initial implementation of `core_float_math` #138087

tgross35 commented Mar 6, 2025 •

edited

Loading

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

tgross35 commented Mar 6, 2025

tgross35 commented Apr 29, 2025

bors commented Apr 29, 2025

matthiaskrgr commented Apr 30, 2025

beetrees commented Apr 30, 2025 •

edited

Loading

tgross35 commented Apr 30, 2025

tgross35 commented Apr 30, 2025

bors commented Apr 30, 2025

tgross35 commented Apr 30, 2025

This comment has been minimized.

tgross35 commented May 1, 2025

bors commented May 1, 2025

bors commented May 1, 2025

Initial implementation of core_float_math #138087

Are you sure you want to change the base?

Initial implementation of core_float_math #138087

Conversation

tgross35 commented Mar 6, 2025 • edited Loading

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

tgross35 commented Mar 6, 2025

tgross35 commented Apr 29, 2025

bors commented Apr 29, 2025

matthiaskrgr commented Apr 30, 2025

beetrees commented Apr 30, 2025 • edited Loading

tgross35 commented Apr 30, 2025

tgross35 commented Apr 30, 2025

bors commented Apr 30, 2025

tgross35 commented Apr 30, 2025

This comment has been minimized.

tgross35 commented May 1, 2025

bors commented May 1, 2025

bors commented May 1, 2025

Initial implementation of `core_float_math` #138087

Initial implementation of `core_float_math` #138087

tgross35 commented Mar 6, 2025 •

edited

Loading

beetrees commented Apr 30, 2025 •

edited

Loading