[EXPERIMENTAL] Test failure investigation #139561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Oli Scherer <[email protected]>
Where the error relevant for these tests is emitted in `report_selection_error` in `fulfillment_errors.rs`, there's a check for the diagostic width. If the explanation is too wide for that width, it's moved to the `help` instead. This was causing the results from CI to not match the results observed in blessing the test locally. Let's update the relevant tests to fix this width and to test it both in a `narrow` and in a `wide` configuration. Thanks to jieyouxu for figuring this out.
rustbot
added
S-waiting-on-review
jieyouxu
removed
the
S-waiting-on-review
RalfJung
reviewed
Apr 10, 2025
| @@ -7,9 +7,7 @@ | |||
| // explanation is moved to the `help` instead of the span label. | |||
| // | |||
| //@ edition: 2024 | |||
| //@ revisions: narrow wide | |||
| //@[narrow] compile-flags: --diagnostic-width=20 | |||
| //@[wide] compile-flags: --diagnostic-width=300 | |||
There was a problem hiding this comment.
This looks almost like the test intentionally wants to cover different widths?
There was a problem hiding this comment.
(Yes, I'm just checking if the original version of the test passes without manually specifying diag width, since it failed in CI but not locally)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #137725.
r? ghost
@rustbot label +S-experimental