Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 11, 2025

r? @RalfJung

just avoiding some minor duplication

@rustbot

This comment was marked as outdated.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2025
@rustbot rustbot assigned RalfJung and unassigned jieyouxu Apr 11, 2025
@RalfJung
Copy link
Member

I didn't know about GlobalAlloc::address_space, but this seems to make sense. :)

r=me when CI is happy.

@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 11, 2025

@bors r=RalfJung rollup

@bors
Copy link
Collaborator

bors commented Apr 11, 2025

📌 Commit cfa52e4 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Rollup of 7 pull requests

Successful merges:

 - rust-lang#137835 (Use `BinOp::Cmp` for `iNN::signum`)
 - rust-lang#139584 (Avoid a reverse map that is only used in diagnostics paths)
 - rust-lang#139638 (Cleanup the `InstSimplify` MIR transformation)
 - rust-lang#139653 (Handle a negated literal in `eat_token_lit`.)
 - rust-lang#139662 (Tweak `DefPathData`)
 - rust-lang#139664 (Reuse address-space computation from global alloc)
 - rust-lang#139687 (Add spastorino to users_on_vacation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eea366c into rust-lang:master Apr 11, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2025
Rollup merge of rust-lang#139664 - oli-obk:push-tkmurytmnsyw, r=RalfJung

Reuse address-space computation from global alloc

r? `@RalfJung`

just avoiding some minor duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants