Skip to content

Update cargo #140362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update cargo #140362

merged 1 commit into from
Apr 28, 2025

Conversation

weihanglo
Copy link
Member

10 commits in d811228b14ae2707323f37346aee3f4147e247e6..7918c7eb59614c39f1c4e27e99d557720976bdd7
2025-04-15 15:18:42 +0000 to 2025-04-27 09:44:23 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

📌 Commit 2985eb8 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2025
@bors
Copy link
Collaborator

bors commented Apr 27, 2025

⌛ Testing commit 2985eb8 with merge deb9479...

@bors
Copy link
Collaborator

bors commented Apr 28, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing deb9479 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2025
@bors bors merged commit deb9479 into rust-lang:master Apr 28, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 28, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cb31a00 (parent) -> deb9479 (this PR)

Test differences

Show 33095 test diffs

Stage 1

  • errors::verify_builtin_macros_asm_mutually_exclusive_65: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_invalid_monomorphization_expected_return_type_112: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_invalid_monomorphization_simd_input_96: pass -> [missing] (J0)
  • errors::verify_interface_ferris_identifier_2: pass -> [missing] (J0)
  • errors::verify_parse_underscore_literal_suffix_138: pass -> [missing] (J0)
  • errors::verify_passes_missing_const_stab_attr_156: pass -> [missing] (J0)
  • errors::verify_passes_unreachable_due_to_uninhabited_164: pass -> [missing] (J0)
  • lints::verify_lint_overflowing_uint_84: pass -> [missing] (J0)
  • opaque::tests::test_u16: pass -> [missing] (J0)
  • opaque::tests::test_unit_like_struct: pass -> [missing] (J0)
  • parser::tests::string_to_tts_macro: pass -> [missing] (J0)
  • session_diagnostics::verify_driver_impl_rlink_corrupt_file_7: pass -> [missing] (J0)
  • snapshot_map::tests::out_of_order: pass -> [missing] (J0)
  • spec::tests::riscv64gc_unknown_nuttx_elf: pass -> [missing] (J0)
  • big_math: pass -> [missing] (J1)
  • collections::btree::set::tests::test_iter_min_max: pass -> [missing] (J1)
  • collections::hash::map::tests::test_extract_if::pred_panic_reuse: pass -> [missing] (J1)
  • f64::test_min_nan: pass -> [missing] (J1)
  • fmt::builders::debug_list::test_multiple_non_exhaustive: pass -> [missing] (J1)
  • fmt::builders::debug_list::test_nested_non_exhaustive: pass -> [missing] (J1)
  • iter::adapters::fuse::test_fuse_count: pass -> [missing] (J1)
  • iter::adapters::map_windows::check_zero_window: pass -> [missing] (J1)
  • mpmc::oneshot_single_thread_recv_chan_close: pass -> [missing] (J1)
  • num::bignum::test_is_zero: pass -> [missing] (J1)
  • num::test_i128_to_string: pass -> [missing] (J1)
  • num::test_try_u64isize: pass -> [missing] (J1)
  • num::u64::test_rotate: pass -> [missing] (J1)
  • slice::test_copy_from_slice_dst_shorter: pass -> [missing] (J1)
  • slice::test_rchunks_exact_iterator: pass -> [missing] (J1)
  • slice::test_windows_last: pass -> [missing] (J1)
  • str::test_le: pass -> [missing] (J1)
  • str::test_replace_2c: pass -> [missing] (J1)
  • vec::extract_if_false: pass -> [missing] (J1)
  • vec::test_extend_from_within_empty_rande: pass -> [missing] (J1)
  • btree::set::is_subset_10k_vs_10k: pass -> [missing] (J2)
  • fs::tests::file_test_fileinfo_check_exists_before_and_after_file_creation: pass -> [missing] (J2)
  • iter::bench_fuse_chain_sum: pass -> [missing] (J2)
  • iter::bench_next_chunk_filter_even: pass -> [missing] (J2)
  • net::tcp::tests::set_nonblocking: pass -> [missing] (J2)
  • sort::tests::stable::correct_dyn_val_saw_mixed: pass -> [missing] (J2)
  • sort::tests::stable::self_cmp_string_ascending: pass -> [missing] (J2)
  • stats::tests::test_sum_f64s: pass -> [missing] (J2)
  • vec::test_try_reserve_exact: pass -> [missing] (J2)
  • sort::tests::stable::correct_cell_i32_random_d20: ignore -> [missing] (J4)
  • sort::tests::unstable::correct_i32_random_d1024: ignore -> [missing] (J4)
  • sort::tests::unstable::stability_i32_random: ignore -> [missing] (J4)
  • sort::tests::unstable::stability_i32_random_d2: ignore -> [missing] (J4)

Stage 2

  • errors::verify_builtin_macros_env_not_defined_55: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_missing_cpp_build_tool_component_46: [missing] -> pass (J0)
  • errors::verify_codegen_ssa_rlib_missing_format_40: [missing] -> pass (J0)
  • errors::verify_const_eval_max_num_nodes_in_const_8: [missing] -> pass (J0)
  • errors::verify_parse_inclusive_range_no_end_35: [missing] -> pass (J0)
  • errors::verify_passes_doc_alias_not_string_literal_27: [missing] -> pass (J0)
  • errors::verify_session_sanitizer_cfi_generalize_pointers_requires_cfi_15: [missing] -> pass (J0)
  • lints::verify_lint_builtin_missing_copy_impl_24: [missing] -> pass (J0)
  • parser::tests::different_note_3: [missing] -> pass (J0)
  • session_diagnostics::verify_attr_parsing_missing_note_4: [missing] -> pass (J0)
  • array::array_map_drop_safety: [missing] -> pass (J1)
  • collections::hash::map::tests::test_find: [missing] -> pass (J1)
  • collections::vec_deque::tests::test_split_off: [missing] -> pass (J1)
  • f128::test_clamp_max_is_nan: [missing] -> pass (J1)
  • fmt::builders::debug_list::test_empty_non_exhaustive: [missing] -> pass (J1)
  • hint::select_unpredictable_drop: [missing] -> pass (J1)
  • io::util::tests::repeat_repeats: [missing] -> pass (J1)
  • iter::adapters::skip::test_iterator_skip_count: [missing] -> pass (J1)
  • net::ip_addr::test_from_str_ipv4_in_ipv6: [missing] -> pass (J1)
  • nonzero::test_match_option_empty_string: [missing] -> pass (J1)
  • num::bignum::test_fmt: [missing] -> pass (J1)
  • num::f64::div_euclid: [missing] -> pass (J1)
  • num::int_log::checked_ilog: [missing] -> pass (J1)
  • num::int_sqrt::i16::isqrt: [missing] -> pass (J1)
  • num::test_try_u16i32: [missing] -> pass (J1)
  • ptr::test_as_ref: [missing] -> pass (J1)
  • rwlock::test_into_inner_drop: [missing] -> pass (J1)
  • slice::test_copy_from_slice: [missing] -> pass (J1)
  • slice::test_slice_partition_dedup_empty: [missing] -> pass (J1)
  • str::pattern::str_searcher_ascii_haystack::bwd: [missing] -> pass (J1)
  • string::test_simple_types: [missing] -> pass (J1)
  • string::test_unsized_to_string: [missing] -> pass (J1)
  • test_prefix_ext: [missing] -> pass (J1)
  • vec::test_extend_from_within_clone: [missing] -> pass (J1)
  • iter::bench_for_each_chain_ref_fold: [missing] -> pass (J2)
  • iter::bench_zip_add: [missing] -> pass (J2)
  • net::addr_parser::bench_parse_ipaddr_v6_compress: [missing] -> pass (J2)
  • num::flt2dec::strategy::grisu::bench_trailing_zero_exact_inf: [missing] -> pass (J2)
  • num::int_pow::checked_pow_variable: [missing] -> pass (J2)
  • slice::sort_small_descending: [missing] -> pass (J2)
  • sort::tests::stable::correct_u64_ascending: [missing] -> pass (J2)
  • sort::tests::stable::deterministic_string_random: [missing] -> pass (J2)
  • sort::tests::stable::observable_is_less_random_s95: [missing] -> pass (J2)
  • sort::tests::stable::self_cmp_string_random_d2: [missing] -> pass (J2)
  • sort::tests::stable::stability_string_random: [missing] -> pass (J2)
  • sort::tests::unstable::panic_retain_orig_set_string_saw_mixed: [missing] -> pass (J2)
  • sort::tests::unstable::stability_i32_random_s95: [missing] -> pass (J2)
  • str::char_count::emoji_huge::case01_filter_count_cont_bytes: [missing] -> pass (J2)
  • str::split_a_str::short_mixed: [missing] -> pass (J2)
  • vec::bench_clone_from_01_0000_1000: [missing] -> pass (J2)
  • os::unix::net::tests::test_abstract_no_pathname_and_not_unnamed: [missing] -> pass (J3)
  • sort::tests::stable::correct_u128_random_d2: [missing] -> ignore (J4)
  • sort::tests::unstable::panic_retain_orig_set_cell_i32_random: [missing] -> ignore (J4)

(and 16477 additional test diffs)

Additionally, 16518 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard deb947971c8748f5c6203548ce4af9022f21eaf0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5785.8s -> 1204.8s (-79.2%)
  2. test-various: 4158.3s -> 2249.2s (-45.9%)
  3. x86_64-apple-1: 8096.9s -> 4438.6s (-45.2%)
  4. x86_64-gnu-aux: 5845.1s -> 4195.0s (-28.2%)
  5. dist-apple-various: 5995.3s -> 7228.1s (20.6%)
  6. aarch64-apple: 3806.7s -> 3152.0s (-17.2%)
  7. dist-x86_64-apple: 8583.1s -> 9767.1s (13.8%)
  8. x86_64-gnu-llvm-19-2: 5835.3s -> 6299.0s (7.9%)
  9. dist-aarch64-apple: 5032.2s -> 4729.9s (-6.0%)
  10. i686-msvc-2: 7199.2s -> 7583.2s (5.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (deb9479): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.7%, 0.9%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.7%, 0.9%] 2

Cycles

Results (primary -0.5%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [1.8%, 2.3%] 4
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 761.979s -> 763.193s (0.16%)
Artifact size: 365.07 MiB -> 365.16 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants