Subtree update of `rust-analyzer` #140385

lnicola · 2025-04-28T08:48:02Z

r? @ghost

fix: Fix, clarify and require a value for `proc_macro_cwd` of `CrateData`

- Fix rust-lang#18782

Fix debug sourceFileMap when using cppvsdbg

fix: Cleanup param name inlay hint filtering

fix: Fix new nightly lints

chore: Clean CI a bit

…s-report fix: Fix panic in progress due to splitting unicode incorrectly

We can compute the wanted information from the block's interned data.

Avoid relying on `block_def_map()` needlessly

It doesn't actually work with merge groups ...

chore: Disable rust-cache in CI

chore: Replace some `invoke`s with `invoke_actual` in hir-ty

chore: Remove unnecessary `Arc` clones

…er bug in MBE Specifically, rust-lang#18744 was the PR that was supposed to fix the old bug, but it fixed it incorrectly (and didn't add a test!) The underlying reason was that we marked metavariables in expansions as joint if they were joint in the macro call, which is incorrect. This wrong fix causes other bug, rust-lang#19497, which this PR fixes by removing the old (incorrect) fix.

This was being used by a single assist, which qualifies under the "refactor" kind. The variant has been removed, and all usages updated accordingly. Signed-off-by: Prajwal S N <[email protected]>

Signed-off-by: Prajwal S N <[email protected]>

fix(ide-assists): remove `AssistKind::None`

…s-string Fix color brackets in string context

Signed-off-by: Prajwal S N <[email protected]>

A Cargo project can now be built without any dependency metadata being fetched. Signed-off-by: Prajwal S N <[email protected]>

Implicit field references during struct initialization were being dropped because get_definition was returning None because there were multiple definitions. This adds a new helper, `get_defintions`, that supports returning more than one definition for a given token and hooks it up. Fixes rust-lang#19393

rustbot · 2025-04-28T09:12:17Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

lnicola · 2025-04-28T12:29:03Z

Quick r? on the license thing, please @davidtwco, @wesleywiser?

rustbot · 2025-04-28T12:29:07Z

Failed to set assignee to on: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

lnicola · 2025-04-30T05:57:25Z

r? @Veykril

rustbot · 2025-04-30T05:57:27Z

Failed to set assignee to Veykril: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

Veykril · 2025-04-30T07:13:40Z

Given foldhash with that license is allowed in cargo already this should be fine
@bors r+ p=1

bors · 2025-04-30T07:14:15Z

📌 Commit ce6a066 has been approved by Veykril

It is now in the queue for this repository.

Subtree update of `rust-analyzer` r? `@ghost`

Rollup of 14 pull requests Successful merges: - rust-lang#140380 (transmutability: uninit transition matches unit byte only) - rust-lang#140385 (Subtree update of `rust-analyzer`) - rust-lang#140395 (organize and extend forbidden target feature tests) - rust-lang#140430 (Improve test coverage of HIR pretty printing.) - rust-lang#140458 (Fix for async drop ice with partly dropped tuple) - rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19) - rust-lang#140465 (chore: edit and move tests) - rust-lang#140467 (Don't FCW assoc consts in patterns) - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing) - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4) - rust-lang#140476 (chore: delete unused ui/auxiliary crates) - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs) - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain) - rust-lang#140494 (Parser: Document restrictions) r? `@ghost` `@rustbot` modify labels: rollup

Subtree update of `rust-analyzer` r? ``@ghost``

Rollup of 13 pull requests Successful merges: - rust-lang#140380 (transmutability: uninit transition matches unit byte only) - rust-lang#140385 (Subtree update of `rust-analyzer`) - rust-lang#140395 (organize and extend forbidden target feature tests) - rust-lang#140458 (Fix for async drop ice with partly dropped tuple) - rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19) - rust-lang#140465 (chore: edit and move tests) - rust-lang#140467 (Don't FCW assoc consts in patterns) - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing) - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4) - rust-lang#140476 (chore: delete unused ui/auxiliary crates) - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs) - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain) - rust-lang#140494 (Parser: Document restrictions) r? `@ghost` `@rustbot` modify labels: rollup

Subtree update of `rust-analyzer` r? ```@ghost```

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#140380 (transmutability: uninit transition matches unit byte only) - rust-lang#140385 (Subtree update of `rust-analyzer`) - rust-lang#140458 (Fix for async drop ice with partly dropped tuple) - rust-lang#140465 (chore: edit and move tests) - rust-lang#140467 (Don't FCW assoc consts in patterns) - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing) - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4) - rust-lang#140476 (chore: delete unused ui/auxiliary crates) - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs) - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain) - rust-lang#140494 (Parser: Document restrictions) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#140385 (Subtree update of `rust-analyzer`) - rust-lang#140458 (Fix for async drop ice with partly dropped tuple) - rust-lang#140465 (chore: edit and move tests) - rust-lang#140467 (Don't FCW assoc consts in patterns) - rust-lang#140468 (Minor tweaks to make some normalization (adjacent) code less confusing) - rust-lang#140470 (CI: rfl: move job forward to Linux v6.15-rc4) - rust-lang#140476 (chore: delete unused ui/auxiliary crates) - rust-lang#140481 (Require sanitizers be enabled for asan_odr_windows.rs) - rust-lang#140486 (rustfmt: Also allow bool literals as first item of let chain) - rust-lang#140494 (Parser: Document restrictions) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-04-30T23:56:14Z

⌛ Testing commit ce6a066 with merge b45dd71...

Rollup merge of rust-lang#140385 - lnicola:sync-from-ra, r=Veykril Subtree update of `rust-analyzer` r? ````@ghost````

Veykril and others added 30 commits March 29, 2025 07:24

Merge pull request rust-lang#19474 from Veykril/push-nokkzzvwynnt

281ca97

fix: Fix, clarify and require a value for `proc_macro_cwd` of `CrateData`

Fix debug sourceFileMap when using cppvsdbg

814d7c3

- Fix rust-lang#18782

Merge pull request rust-lang#19475 from inflation/push-xrwpqzsqxtuy

a2083a5

Fix debug sourceFileMap when using cppvsdbg

fix: Cleanup param name inlay hint filtering

a451b04

Merge pull request rust-lang#19482 from Veykril/push-orrorupvlqpt

8c7aa53

fix: Cleanup param name inlay hint filtering

fix: Fix new nightly lints

ed75e2a

Merge pull request rust-lang#19484 from Veykril/push-ttvnzlkvwssk

03fee91

fix: Fix new nightly lints

chore: Clean CI a bit

73a3d4a

Merge pull request rust-lang#19485 from Veykril/push-mqlnvzkuplnm

bca0d60

chore: Clean CI a bit

fix: Fix panic in progress due to splitting unicode incorrectly

f8a9c92

Merge pull request rust-lang#19490 from rossdylan/fix-unicode-progres…

409e0ac

…s-report fix: Fix panic in progress due to splitting unicode incorrectly

Avoid relying on block_def_map() needlessly

ad7c4cf

We can compute the wanted information from the block's interned data.

Merge pull request rust-lang#19492 from ChayimFriedman2/experiment

6698106

Avoid relying on `block_def_map()` needlessly

chore: Disable rust-cache in CI

b0fbec6

It doesn't actually work with merge groups ...

Merge pull request rust-lang#19493 from Veykril/push-tlwonkmlonqv

fabb6fd

chore: Disable rust-cache in CI

chore: Replace some invokes with invoke_actual in hir-ty

0394116

chore: Remove unnecessary Arc clones

6e8a96e

Merge pull request rust-lang#19496 from Veykril/push-zuwsrswwtzsu

73d8cd8

chore: Replace some `invoke`s with `invoke_actual` in hir-ty

Merge pull request rust-lang#19494 from Veykril/push-uzmzppouxuvr

280c133

chore: Remove unnecessary `Arc` clones

fix(ide-assists): remove AssistKind::None

3c573ca

This was being used by a single assist, which qualifies under the "refactor" kind. The variant has been removed, and all usages updated accordingly. Signed-off-by: Prajwal S N <[email protected]>

feat(proc-macro-srv): support metadata version 10

59240a9

Signed-off-by: Prajwal S N <[email protected]>

Merge pull request rust-lang#19509 from snprajwal/remove-assistid-none

8408e28

fix(ide-assists): remove `AssistKind::None`

fix language-configuration.json

3aa1b60

Merge pull request rust-lang#19514 from BenjaminBrienen/color-bracket…

9c5cdfe

…s-string Fix color brackets in string context

chore: clean up some FIXMEs

e9bad9c

Signed-off-by: Prajwal S N <[email protected]>

feat(project-model): provide flag for no deps

4bf481c

A Cargo project can now be built without any dependency metadata being fetched. Signed-off-by: Prajwal S N <[email protected]>

prefer default over new

9a43f02

internal: fix panic in view_crate_graph

b7bc8d0

Add foldhash license exception

36ed4aa

rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 28, 2025

This comment has been minimized.

Sign in to view

Unelide lifetime

ce6a066

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2025

Zalathar mentioned this pull request Apr 30, 2025

Rollup of 14 pull requests #140501

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025

Rollup merge of rust-lang#140385 - lnicola:sync-from-ra, r=Veykril

92d801f

Subtree update of `rust-analyzer` r? `@ghost`

Zalathar mentioned this pull request Apr 30, 2025

Rollup of 13 pull requests #140510

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 30, 2025

Rollup merge of rust-lang#140385 - lnicola:sync-from-ra, r=Veykril

335ddb6

Subtree update of `rust-analyzer` r? ``@ghost``

matthiaskrgr mentioned this pull request Apr 30, 2025

Rollup of 11 pull requests #140528

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 30, 2025

Rollup merge of rust-lang#140385 - lnicola:sync-from-ra, r=Veykril

54ea107

Subtree update of `rust-analyzer` r? ```@ghost```

matthiaskrgr mentioned this pull request Apr 30, 2025

Rollup of 10 pull requests #140529

Merged

bors merged commit f8f4d2d into rust-lang:master Apr 30, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 30, 2025

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2025

Unrolled build for rust-lang#140385

9dcdd47

Rollup merge of rust-lang#140385 - lnicola:sync-from-ra, r=Veykril Subtree update of `rust-analyzer` r? ````@ghost````

lnicola deleted the sync-from-ra branch May 1, 2025 03:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Subtree update of `rust-analyzer` #140385

Subtree update of `rust-analyzer` #140385

Uh oh!

lnicola commented Apr 28, 2025

Uh oh!

rustbot commented Apr 28, 2025

Uh oh!

This comment has been minimized.

lnicola commented Apr 28, 2025

Uh oh!

rustbot commented Apr 28, 2025

Uh oh!

lnicola commented Apr 30, 2025

Uh oh!

rustbot commented Apr 30, 2025

Uh oh!

Veykril commented Apr 30, 2025

Uh oh!

bors commented Apr 30, 2025

Uh oh!

Uh oh!

bors commented Apr 30, 2025

Uh oh!

Uh oh!

Subtree update of rust-analyzer #140385

Subtree update of rust-analyzer #140385

Uh oh!

Conversation

lnicola commented Apr 28, 2025

Uh oh!

rustbot commented Apr 28, 2025

Uh oh!

This comment has been minimized.

lnicola commented Apr 28, 2025

Uh oh!

rustbot commented Apr 28, 2025

Uh oh!

lnicola commented Apr 30, 2025

Uh oh!

rustbot commented Apr 30, 2025

Uh oh!

Veykril commented Apr 30, 2025

Uh oh!

bors commented Apr 30, 2025

Uh oh!

Uh oh!

bors commented Apr 30, 2025

Uh oh!

Uh oh!

Subtree update of `rust-analyzer` #140385

Subtree update of `rust-analyzer` #140385