Rollup of 12 pull requests #140565
Merged
Rollup of 12 pull requests #140565
+755
−422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pudongair <[email protected]>
If you want to logically split an iterator after `n` items, you might first discover `take`. Before this change, you'd find that `take` consumes the iterator, and you'd probably be stuck. The answer involves `by_ref`, but that's hard to discover, especially since `by_ref` is a bit abstract and `Iterator` has many methods. After this change, you'd see the example showing `take` along with `by_ref`, which allows you to continue using the rest of the iterator. `by_ref` had a good example involving `take` already, so this change just duplicates that existing example under `take`.
* "while until either" could also be changed to "for a while until either", but I just deleted "while". * fixed sentence with incorrect "at" and "has/have". * linked [*currently allocated*] similar to other methods.
…rrently written into Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
I found "Rustc dev guide subtree update awkward"
It was observed that some people were missing the `edition20xx` rustdoc attribute. Although this probably won't solve that problem, I'd still like to highlight it as something to be aware of.
…rary Based on lessons learned from 2024. There's probably still more details to say here since it was a ton of work. These are the major points that I remember.
This updates to the latest version of mdbook which has had a variety of fixes of new features since the last update. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0448
This adds documentation on how to stabilize the edition in the compiler.
Refactor the dependency structure from a nested unordered list to a single-level ordered list. IMO, this is clearer, but happy to close this PR without merging, if the change is not desired.
Introduce a normalization chapter
Fix footnotes
Update compiler-src.md
Also, these are normal Rust things (crates/packages), so remove the word *normal*.
rustc-dev-guide subtree update r? ``@ghost``
… r=fee1-dead
Clean up "const" situation in format_args!().
This cleans up the "const" situation in the format_args!() expansion/lowering.
Rather than marking the Argument::new_display etc. functions as non-const, this marks the Arguments::new_v1 functions as non-const.
Example expansion/lowering of format_args!() in const:
```rust
// Error: cannot call non-const formatting macro in constant functions
const {
fmt::Arguments::new_v1( // Now the error is produced here.
&["Hello, ", "!\n"],
&[
fmt::Argument::new_display(&world) // The error used to be produced here.
],
)
}
```
…d_internal_symbol, r=bjorn3 allow `#[rustc_std_internal_symbol]` in combination with `#[naked]` The need for this came up in rust-lang/compiler-builtins#897, but in general this seems useful and valid to allow. Based on a quick scan, I don't think changes to the generated assembly are needed. cc ``@bjorn3``
…-tool-error-output, r=clubby789 Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite Fixes rust-lang#138134. It now looks like this:  cc ``@kpreid``
rustbot
added
A-attributes
|
@bors r+ p=5 rollup=never |
bors
added
S-waiting-on-bors
VlaDexa
added a commit
to VlaDexa/rust
that referenced
this pull request
May 2, 2025
…uillaumeGomez Rollup of 12 pull requests Successful merges: - rust-lang#138703 (chore: remove redundant words in comment) - rust-lang#139186 (Refactor `diy_float`) - rust-lang#139780 (docs: Add example to `Iterator::take` with `by_ref`) - rust-lang#139802 (Fix some grammar errors and hyperlinks in doc for `trait Allocator`) - rust-lang#140034 (simd_select_bitmask: the 'padding' bits in the mask are just ignored) - rust-lang#140062 (std: mention `remove_dir_all` can emit `DirectoryNotEmpty` when concurrently written into) - rust-lang#140420 (rustdoc: Fix doctest heuristic for main fn wrapping) - rust-lang#140460 (Fix handling of LoongArch target features not supported by LLVM 19) - rust-lang#140538 (rustc-dev-guide subtree update) - rust-lang#140544 (Clean up "const" situation in format_args!(). ) - rust-lang#140552 (allow `#[rustc_std_internal_symbol]` in combination with `#[naked]`) - rust-lang#140556 (Improve error output in case `nodejs` or `npm` is not installed for rustdoc-gui test suite) r? `@ghost` `@rustbot` modify labels: rollup
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 2, 2025
Tested on commit rust-lang/rust@cb0d6e7. Direct link to PR: <rust-lang/rust#140565> 🎉 reference on windows: test-fail → test-pass (cc @ehuss). 🎉 reference on linux: test-fail → test-pass (cc @ehuss).
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3350c1e (parent) -> cb0d6e7 (this PR) Test differencesShow 592 test diffsStage 1
Stage 2
Additionally, 576 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cb0d6e76d0515b19d249c0147d246296b9d3d124 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 3350c1eb3f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (cb0d6e7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.0%, secondary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 767.941s -> 768.128s (0.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
diy_float#139186 (Refactordiy_float)Iterator::takewithby_ref#139780 (docs: Add example toIterator::takewithby_ref)trait Allocator#139802 (Fix some grammar errors and hyperlinks in doc fortrait Allocator)remove_dir_allcan emitDirectoryNotEmptywhen concurrently written into #140062 (std: mentionremove_dir_allcan emitDirectoryNotEmptywhen concurrently written into)#[rustc_std_internal_symbol]in combination with#[naked]#140552 (allow#[rustc_std_internal_symbol]in combination with#[naked])nodejsornpmis not installed for rustdoc-gui test suite #140556 (Improve error output in casenodejsornpmis not installed for rustdoc-gui test suite)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup