Reduce special casing for the panic runtime #140809
Merged
+64
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_ssa |
|
I was looking at making panic_abort and panic_unwind depend on libstd (#139103 (comment)). These changes make this easier, though is still blocked on the fact that when compiling libstd as dylib, panic_unwind already needs to be present. |
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
6d4613c to
c7e8663
Compare
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
c7e8663 to
93cf365
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
93cf365 to
a9d5498
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
d730005 to
7d0f158
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
7d0f158 to
0dfacc7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bjorn3
force-pushed
the
panic_runtime_cleanup
branch
from
0dfacc7 to
6df5456
Compare
|
r? wesleywiser |
wesleywiser
approved these changes
Jun 6, 2025
|
Compiler changes look good to me but I'd like someone from libs to review the change in exposed standard library features to make sure there's no concerns there. r? libs |
|
Looks fine to me. @bors r=wesleywiser,ibraheemdev |
bors
removed
the
S-waiting-on-review
|
|
|
r? compiler |
|
r? compiler |
petrochenkov
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Thanks! |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 27, 2025
…trochenkov Reduce special casing for the panic runtime See the individual commits for more info.
bors
added a commit
that referenced
this pull request
Jun 27, 2025
…rors Rollup of 8 pull requests Successful merges: - #139858 (New const traits syntax) - #140809 (Reduce special casing for the panic runtime) - #142963 (Skip unnecessary components in x64 try builds) - #142974 (Update stage0 to 1.89.0-beta.1) - #142987 (rustdoc: show attributes on enum variants) - #143002 (tests: Require `run-fail` ui tests to have an exit code (`SIGABRT` not ok)) - #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology) - #143096 (tag_for_variant: properly pass TypingEnv) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 27, 2025
Rollup of 9 pull requests Successful merges: - #139858 (New const traits syntax) - #140809 (Reduce special casing for the panic runtime) - #142730 (suggest declaring modules when file found but module not defined) - #142806 (Normalize before computing ConstArgHasType goal in new solver) - #143046 (const validation: properly ignore zero-sized UnsafeCell) - #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology) - #143096 (tag_for_variant: properly pass TypingEnv) - #143104 (hir_analysis: prohibit `dyn PointeeSized`) - #143106 (gce: don't ICE on non-local const) Failed merges: - #143036 (Remove support for `dyn*` from the compiler) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 28, 2025
Rollup merge of #140809 - bjorn3:panic_runtime_cleanup, r=petrochenkov Reduce special casing for the panic runtime See the individual commits for more info.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jun 28, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#139858 (New const traits syntax) - rust-lang/rust#140809 (Reduce special casing for the panic runtime) - rust-lang/rust#142730 (suggest declaring modules when file found but module not defined) - rust-lang/rust#142806 (Normalize before computing ConstArgHasType goal in new solver) - rust-lang/rust#143046 (const validation: properly ignore zero-sized UnsafeCell) - rust-lang/rust#143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology) - rust-lang/rust#143096 (tag_for_variant: properly pass TypingEnv) - rust-lang/rust#143104 (hir_analysis: prohibit `dyn PointeeSized`) - rust-lang/rust#143106 (gce: don't ICE on non-local const) Failed merges: - rust-lang/rust#143036 (Remove support for `dyn*` from the compiler) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for more info.