Rollup of 8 pull requests #140818
Merged
Rollup of 8 pull requests #140818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get rid of the `Ident::empty` uses. This requires introducing `PathParser::word_sym`, as an alternative to `PathParser::word`.
By using `@` patterns more. Also, use `Symbol` more in a couple of errors to avoid some unnecessary conversions to strings. This even removes a lifetime.
…f they are provided
And note that the same limitation applies to all LLVM-based compilers Co-authored-by: Ralf Jung <[email protected]>
…onszelmann Eliminate `word_and_empty` methods. To remove the last remaining `Ident::empty` uses. r? `@jdonszelmann`
…ulacrum Clarify black_box warning a bit Trying to bring the docs on black_box more in line with the advice that we have discussed in Zulip. rust-lang#140341 (comment)
… r=lcnr Only include `dyn Trait<Assoc = ...>` associated type bounds for `Self: Sized` associated types if they are provided Since rust-lang#136458, we began filtering out associated types with `Self: Sized` bounds when constructing the list of associated type bounds to put into our `dyn Trait` types. For example, given: ```rust trait Trait { type Assoc where Self: Sized; } ``` After rust-lang#136458, even if a user writes `dyn Trait<Assoc = ()>`, the lowered ty would have an empty projection list, and thus be equivalent to `dyn Trait`. However, this has the side effect of no longer constraining any types in the RHS of `Assoc = ...`, not implying any WF implied bounds, and not requiring that they hold when unsizing. After this PR, we include these bounds, but (still) do not require that they are provided. If the are not provided, they are skipped from the projections list. This results in `dyn Trait` types that have differing numbers of projection bounds. This will lead to re-introducing type mismatches e.g. between `dyn Trait` and `dyn Trait<Assoc = ()>`. However, this is expected and doesn't suffer from any of the deduplication unsoundness from before rust-lang#136458. We may want to begin to ignore thse bounds in the future by bumping `unused_associated_type_bounds` to an FCW. I don't want to tangle that up into the fix that was originally intended in rust-lang#136458, so I'm doing a "fix-forward" in this PR and deferring thinking about this for the future. Fixes rust-lang#140645 r? lcnr
…orm, r=lcnr Structurally normalize in range pattern checking in HIR typeck Fixes rust-lang/trait-system-refactor-initiative#200 r? lcnr
…=jieyouxu Improve `-Zremap-path-scope` tests with dependency This PR greatly improves our coverage of `-Zremap-path-scope` for diagnostic paths and macros with dependencies. r? `@jieyouxu` (since we talked about it) try-job: x86_64-msvc-1
…oval, r=jieyouxu Make `rustdoc-tempdir-removal` run-make tests work on other platforms than linux Follow-up of rust-lang#140706. r? `@jieyouxu`
…lbini Add release notes for 1.87.0 Originally drafted in rust-lang#140133 cc `@rust-lang/release` r? `@pietroalbani` as you're running the release
Enable triagebot note functionality for rust-lang/rust Docs: <https://forge.rust-lang.org/triagebot/note.html>. r? `@Urgau`
rustbot
added
A-attributes
|
@bors r+ rollup=never p=5 |
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 50aa041807 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 50aa041 (parent) -> 667247d (this PR) Test differencesShow 107 test diffsStage 1
Stage 2
Additionally, 64 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 667247db71ea18c4130dd018d060e7f09d589490 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Merged
|
Finished benchmarking commit (667247d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.1%, secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 772.168s -> 771.655s (-0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
word_and_emptymethods. #140095 (Eliminateword_and_emptymethods.)dyn Trait<Assoc = ...>associated type bounds forSelf: Sizedassociated types if they are provided #140684 (Only includedyn Trait<Assoc = ...>associated type bounds forSelf: Sizedassociated types if they are provided)-Zremap-path-scopetests with dependency #140716 (Improve-Zremap-path-scopetests with dependency)rustdoc-tempdir-removalrun-make tests work on other platforms than linux #140800 (Makerustdoc-tempdir-removalrun-make tests work on other platforms than linux)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup