impl PartialEq<{str,String}> for {Path,PathBuf}
#140956
Open
+71
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
44bb04c to
90838cd
Compare
This comment has been minimized.
This comment has been minimized.
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
90838cd to
c7d5b49
Compare
This comment has been minimized.
This comment has been minimized.
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
c7d5b49 to
f908d17
Compare
This comment has been minimized.
This comment has been minimized.
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions. ACP: rust-lang/libs-team#151
Kixunil
force-pushed
the
impl-partialeq-str-for-path
branch
from
f908d17 to
aab1563
Compare
|
r? libs-api |
rustbot
added
the
T-libs-api
|
Starting a crater run since we've previously had type inference issues with @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2025
… r=<try>
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
If I'm looking at the report correctly (it's crashing my browser, I had to read it in source code :D) the two regressions are unrelated and supposed fixes are likely unrelated as well. |
Amanieu
removed
the
T-libs
|
@rfcbot cancel |
|
@Amanieu proposal cancelled. |
rfcbot
removed
proposed-final-comment-period
|
@rfcbot merge |
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
|
@bors r+ |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 17, 2025
…h, r=Amanieu
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 17, 2025
…h, r=Amanieu
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 17, 2025
…h, r=Amanieu
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 18, 2025
…h, r=Amanieu
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
bors
added a commit
that referenced
this pull request
Aug 18, 2025
Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145486 (Fix `unicode_data.rs` mention message) - #145489 (library: Migrate from `cfg_if` to `cfg_select`) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145516 (Weekly `cargo update`) - #145533 (Reorder `lto` options from most to least optimizing) - #145550 (Avoid using `()` in `derive(From)` output.) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 18, 2025
…h, r=Amanieu
`impl PartialEq<{str,String}> for {Path,PathBuf}`
This is a revival of rust-lang#105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.
ACP: rust-lang/libs-team#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #105877
Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os
PartialEqbetween strings and paths, both owned and unsized, in both directions.ACP: rust-lang/libs-team#151