check coroutines with TypingMode::Borrowck to avoid cyclic reasoning
#141125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
commented
May 17, 2025
compiler-errors
approved these changes
May 17, 2025
MIR borrowck taints its output if an obligation fails. This could then cause `check_coroutine_obligations` to silence its error, causing us to not emit and actual error and ICE.
rust-cloud-vms
bot
force-pushed
the
coroutine_obligations_use_borrowck
branch
from
2babe2a to
667504b
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#135808 (Implement Display for ``rustc_target::callconv::Conv``) - rust-lang#137432 (Add as_ascii_unchecked() methods to char, u8, and str) - rust-lang#139103 (deduplicate abort implementations) - rust-lang#140917 (checktools.sh: fix bashism) - rust-lang#141035 (turn lld warning on old gccs into info log) - rust-lang#141118 (Enable rust-analyzer to go from query definition to the corresponding provider field) - rust-lang#141121 (Only select true errors in `impossible_predicates`) - rust-lang#141125 (check coroutines with `TypingMode::Borrowck` to avoid cyclic reasoning) - rust-lang#141131 (Make some `match`es slightly more ergonomic in `librustdoc`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2025
Rollup merge of rust-lang#141125 - lcnr:coroutine_obligations_use_borrowck, r=compiler-errors check coroutines with `TypingMode::Borrowck` to avoid cyclic reasoning MIR borrowck taints its output if an obligation fails. This could then cause `check_coroutine_obligations` to silence its error, causing us to not emit and actual error and ICE. Fixes the ICE in rust-lang/trait-system-refactor-initiative#199. It is unfortunately still a regression. r? compiler-errors
lcnr
added
the
WG-trait-system-refactor
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIR borrowck taints its output if an obligation fails. This could then cause
check_coroutine_obligationsto silence its error, causing us to not emit and actual error and ICE.Fixes the ICE in rust-lang/trait-system-refactor-initiative#199. It is unfortunately still a regression.
r? compiler-errors