Skip to content

trim cache module in utils bootstrap #141257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

trim cache module in utils bootstrap #141257

merged 1 commit into from
May 20, 2025

Conversation

Shourya742
Copy link
Contributor

@Shourya742 Shourya742 commented May 19, 2025 •
edited
Loading

We don't use other variants of Interner in bootstrap, so this PR streamlines the bootstrap cache utils module.

r? @onur-ozkan

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 19, 2025
@rustbot rustbot assigned onur-ozkan and unassigned albertlarsan68 May 19, 2025
onur-ozkan
onur-ozkan approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 19, 2025

📌 Commit 8ecb128 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025
@Zalathar Zalathar mentioned this pull request May 20, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@bors
Auto merge of rust-lang#141270 - Zalathar:rollup-jd1y1f6, r=Zalathar
a8e4c68 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#141211 (Replace `try_reserve_exact` with `try_with_capacity` in `std::fs::read`)
 - rust-lang#141257 (trim cache module in utils bootstrap)
 - rust-lang#141259 (Update books)
 - rust-lang#141261 (current_dll_path: fix mistake in assertion message)
 - rust-lang#141262 (Properly remove Noratrieb from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 41afd04 into rust-lang:master May 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
@rust-timer
Unrolled build for rust-lang#141257
5897dc2 
Rollup merge of rust-lang#141257 - Shourya742:2025-05-19-trim-cache-module, r=onur-ozkan

trim cache module in utils bootstrap

We don't use other variants of Interner in bootstrap, so this PR streamlines the bootstrap cache utils module.

r? `@onur-ozkan`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@onur-ozkan onur-ozkan

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Shourya742 @rustbot @onur-ozkan @bors @albertlarsan68