add additional `TypeFlags` fast paths #141581

lcnr · 2025-05-26T11:10:29Z

Some crates, e.g. diesel, have items with a lot of where-clauses (more than 150). In these cases checking the TypeFlags of the whole param_env can be very beneficial.

This adds fn fold_clauses to mirror the existing fn visit_clauses and then uses this in folders which fold ParamEnvs.

Split out from #141451, depends on #141442.

r? @compiler-errors

rustbot · 2025-05-26T11:10:35Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

lcnr · 2025-05-26T11:10:39Z

@bors try @rust-timer queue

add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from #141451, depends on #141500. r? `@compiler-errors`

bors · 2025-05-26T11:11:50Z

⌛ Trying commit 1a2a21a with merge 66697d5...

lcnr · 2025-05-26T11:12:01Z

compiler/rustc_next_trait_solver/src/resolve.rs

@@ -22,8 +22,20 @@ where
    cache: DelayedMap<I::Ty, I::Ty>,
 }

+pub fn eager_resolve_vars<D: SolverDelegate, T: TypeFoldable<D::Interner>>(


now that we actually check for has_infer in fold_clauses, this change may be unnecessary again 🤔

bors · 2025-05-26T13:07:37Z

☀️ Try build successful - checks-actions
Build commit: 66697d5 (66697d5810fdd5352481e75e0f8890d3d115ce9e)

rust-timer · 2025-05-26T14:59:02Z

Finished benchmarking commit (66697d5): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.2%]	5
Regressions ❌ (secondary)	0.3%	[0.1%, 0.5%]	15
Improvements ✅ (primary)	-0.7%	[-2.9%, -0.2%]	7
Improvements ✅ (secondary)	-8.1%	[-20.4%, -1.5%]	14
All ❌✅ (primary)	-0.4%	[-2.9%, 0.2%]	12

Max RSS (memory usage)

Results (primary -1.0%, secondary 3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	5.6%	[3.6%, 7.3%]	4
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-1.0%	[-3.0%, 1.1%]	2

Cycles

Results (primary -2.0%, secondary -8.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.0%	[-2.8%, -1.2%]	2
Improvements ✅ (secondary)	-8.3%	[-17.0%, -2.1%]	11
All ❌✅ (primary)	-2.0%	[-2.8%, -1.2%]	2

Binary size

Results (primary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Bootstrap: 776.359s -> 778.786s (0.31%)
Artifact size: 366.28 MiB -> 366.21 MiB (-0.02%)

compiler-errors · 2025-05-26T19:59:35Z

r=me (or i'll r+) after ci green

compiler-errors · 2025-05-26T22:27:04Z

@bors r+ rollup=never

bors · 2025-05-26T22:27:07Z

📌 Commit 0830ce0 has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2025-05-26T22:28:07Z

actually, for good measure, let's perf this alone.

compiler-errors · 2025-05-26T22:28:14Z

@bors r-

compiler-errors · 2025-05-26T22:28:25Z

@bors try @rust-timer queue

bors · 2025-05-26T22:29:35Z

⌛ Trying commit 0830ce0 with merge 9170505...

add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from #141451, depends on #141442. r? `@compiler-errors`

bors · 2025-05-27T00:35:06Z

☀️ Try build successful - checks-actions
Build commit: 9170505 (91705054c0f147bb4f3c51e5dc43cfa46c4ec31a)

rust-timer · 2025-05-27T02:51:11Z

Finished benchmarking commit (9170505): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	7
Regressions ❌ (secondary)	0.3%	[0.1%, 0.5%]	16
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.3%]	5
Improvements ✅ (secondary)	-2.5%	[-5.5%, -0.2%]	10
All ❌✅ (primary)	-0.1%	[-0.4%, 0.1%]	12

Max RSS (memory usage)

Results (primary 1.8%, secondary 5.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	5.8%	[5.8%, 5.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Cycles

Results (secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.5%, -3.3%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.13s -> 779.873s (0.22%)
Artifact size: 366.42 MiB -> 366.32 MiB (-0.03%)

compiler-errors · 2025-05-28T10:15:06Z

I think this perf improvement is a wash, but it's beneficial for nalgebra in the new and old solvers, so I'm still inclined to land it. Maybe some follow-up perf work can be done to tweak inlining and/or remove unnecessary folding is warranted :>

@bors r+ rollup=never

bors · 2025-05-28T10:15:09Z

📌 Commit 0830ce0 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2025-05-29T02:29:05Z

⌛ Testing commit 0830ce0 with merge 5f025f3...

bors · 2025-05-29T05:39:56Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5f025f3 to master...

github-actions · 2025-05-29T05:43:09Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ebe9b00 (parent) -> 5f025f3 (this PR)

Test differences

Show 33280 test diffs

Stage 1

asserting::capture_with_copyable_and_debuggable_elem_has_correct_params: [missing] -> pass (J0)
collections::btree::set::tests::test_difference: [missing] -> pass (J0)
collections::btree::set::tests::test_extract_if: [missing] -> pass (J0)
collections::btree::set::tests::test_remove: [missing] -> pass (J0)
collections::hash::map::tests::test_find: [missing] -> pass (J0)
f64::test_atanh: [missing] -> pass (J0)
floats::f16::test_is_nan: [missing] -> pass (J0)
into: [missing] -> pass (J0)
intrinsics::carrying_mul_add_fallback_u128: [missing] -> pass (J0)
io::buffered::tests::test_buffered_reader: [missing] -> pass (J0)
io::tests::take_seek: [missing] -> pass (J0)
mpmc::recv_from_outside_runtime: [missing] -> pass (J0)
mpsc_sync::send3: [missing] -> pass (J0)
num::test_try_u32u8: [missing] -> pass (J0)
num::u64::test_num: [missing] -> pass (J0)
num::u8::test_le: [missing] -> pass (J0)
ops::test_range_syntax: [missing] -> pass (J0)
slice::test_last: [missing] -> pass (J0)
slice::test_rchunks_exact_mut_count: [missing] -> pass (J0)
str::not_double_ended_rsplitn: [missing] -> pass (J0)
str::test_rev_split_char_iterator_no_trailing: [missing] -> pass (J0)
string::test_push_str: [missing] -> pass (J0)
vec::test_slice_from_mut: [missing] -> pass (J0)
back::apple::tests::lookup_developer_dir: [missing] -> pass (J1)
error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_invalid_format_specifier_6: [missing] -> pass (J1)
errors::verify_ast_lowering_abi_specified_multiple_times_11: [missing] -> pass (J1)
errors::verify_ast_lowering_default_field_in_tuple_0: [missing] -> pass (J1)
errors::verify_ast_passes_match_arm_with_no_body_58: [missing] -> pass (J1)
errors::verify_codegen_ssa_rlib_archive_build_failure_67: [missing] -> pass (J1)
errors::verify_codegen_ssa_xcrun_unsuccessful_140: [missing] -> pass (J1)
errors::verify_expand_expected_paren_or_brace_38: [missing] -> pass (J1)
errors::verify_interface_multiple_output_types_to_stdout_16: [missing] -> pass (J1)
errors::verify_parse_macro_name_remove_bang_153: [missing] -> pass (J1)
errors::verify_passes_should_be_applied_to_fn_13: [missing] -> pass (J1)
lints::verify_lint_invalid_from_utf8_checked_48: [missing] -> pass (J1)
parser::tokenstream::tests::test_concat: [missing] -> pass (J1)
server_impl::token_id::tests::test_ra_server_from_str: [missing] -> pass (J1)
spec::tests::armv7a_nuttx_eabi: [missing] -> pass (J1)
spec::tests::i686_unknown_uefi: [missing] -> pass (J1)
spec::tests::powerpc_unknown_linux_gnuspe: [missing] -> pass (J1)
symbol::tests::without_first_quote_test: [missing] -> pass (J1)
theme::tests::test_with_minification: [missing] -> pass (J1)
transitive_relation::tests::minimal_scc_representative_2: [missing] -> pass (J1)
ascii::long::case11_mask_mult_bool_match_range: [missing] -> pass (J2)
btree::map::first_and_last_100_nightly: [missing] -> pass (J2)
floats::f16::test_round_ties_even: [missing] -> pass (J2)
iter::bench_cycle_skip_take_ref_sum: [missing] -> pass (J2)
net::tcp::tests::write_close: [missing] -> pass (J2)
num::int_log::u16_log_random_small: [missing] -> pass (J2)
num::int_sqrt::i128::isqrt_extended: [missing] -> pass (J2)
num::int_sqrt::u128_sqrt_random: [missing] -> pass (J2)
sort::tests::stable::correct_dyn_val_saw_mixed: [missing] -> pass (J2)
sort::tests::unstable::correct_u64_random_d2: [missing] -> pass (J2)
str::char_iterator_for: [missing] -> pass (J2)
term::terminfo::parm::tests::test_multiple_int_constants: [missing] -> pass (J2)
tests::parse_show_output_flag: [missing] -> pass (J2)
tests::test_bench_once_iter: [missing] -> pass (J2)
slice::select_nth_unstable: [missing] -> ignore (J3)
sort::tests::stable::violate_ord_retain_orig_set_string_random_d2: [missing] -> ignore (J3)

Stage 2

ascii::test_escape_ascii: pass -> [missing] (J0)
atomic::int_nand: pass -> [missing] (J0)
collections::hash::set::tests::test_difference: pass -> [missing] (J0)
fmt::builders::debug_set::test_empty: pass -> [missing] (J0)
iter::adapters::filter::test_iterator_filter_count: pass -> [missing] (J0)
iter::adapters::intersperse::test_intersperse_with: pass -> [missing] (J0)
mutex::test_set: pass -> [missing] (J0)
num::i32::test_bitwise_operators: pass -> [missing] (J0)
num::test_i16f32: pass -> [missing] (J0)
slice::memchr::matches_past_nul: pass -> [missing] (J0)
slice::test_mut_rchunks_exact_rev: pass -> [missing] (J0)
slice::test_total_ord_i32: pass -> [missing] (J0)
str::test_cow_from: pass -> [missing] (J0)
string::test_split_off_past_end: pass -> [missing] (J0)
vec::test_retain_maybeuninits: pass -> [missing] (J0)
vec_deque::test_from_iter: pass -> [missing] (J0)
error::verify_middle_const_not_used_in_type_alias_8: pass -> [missing] (J1)
errors::verify_builtin_macros_alloc_error_must_be_fn_8: pass -> [missing] (J1)
errors::verify_builtin_macros_test_bad_fn_61: pass -> [missing] (J1)
errors::verify_const_eval_mutable_ref_escaping_15: pass -> [missing] (J1)
errors::verify_lint_unsupported_group_2: pass -> [missing] (J1)
errors::verify_parse_use_empty_block_not_semi_31: pass -> [missing] (J1)
errors::verify_passes_incorrect_target_140: pass -> [missing] (J1)
errors::verify_session_unsupported_reg_struct_return_arch_48: pass -> [missing] (J1)
html::render::write_shared::tests::type_alias_template: pass -> [missing] (J1)
html::tests::href_relative_parts_same_module: pass -> [missing] (J1)
lints::verify_lint_builtin_export_name_static_15: pass -> [missing] (J1)
server_impl::token_id::tests::test_ra_server_from_str: pass -> [missing] (J1)
spec::tests::armv5te_none_eabi: pass -> [missing] (J1)
spec::tests::m68k_unknown_linux_gnu: pass -> [missing] (J1)
ascii::is_ascii::unaligned_head_medium::case03_align_to_unrolled: pass -> [missing] (J2)
btree::map::clone_fat_val_100_and_clear: pass -> [missing] (J2)
iter::bench_cycle_skip_take_ref_sum: pass -> [missing] (J2)
num::bench_u8_from_str_radix_2: pass -> [missing] (J2)
num::u16::test_lots_of_isqrt: pass -> [missing] (J2)
slice::rotate_huge_half_plus_one: pass -> [missing] (J2)
str::ends_with_str::short_ascii: pass -> [missing] (J2)
tests::exclude_should_panic_option: pass -> [missing] (J2)
sort::tests::stable::correct_1k_random_d2: ignore -> [missing] (J3)
sort::tests::stable::correct_cell_i32_random_d2: ignore -> [missing] (J3)
sort::tests::stable::panic_observable_is_less_descending: ignore -> [missing] (J3)

(and 16566 additional test diffs)

Additionally, 16614 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
J1: aarch64-apple, x86_64-apple-1
J2: aarch64-apple, test-various, x86_64-apple-1
J3: x86_64-gnu-aux

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5f025f363df11c65bd31ade9fe6f48fd4f4239af --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 1385.5s -> 5492.9s (296.5%)
test-various: 2278.8s -> 4147.7s (82.0%)
x86_64-gnu-aux: 3907.8s -> 5635.7s (44.2%)
aarch64-apple: 3567.9s -> 4495.7s (26.0%)
x86_64-apple-1: 8754.0s -> 7500.4s (-14.3%)
dist-x86_64-apple: 9721.8s -> 8572.4s (-11.8%)
x86_64-mingw-1: 8674.2s -> 9378.2s (8.1%)
dist-x86_64-illumos: 6067.5s -> 5583.4s (-8.0%)
x86_64-msvc-2: 7142.6s -> 6635.5s (-7.1%)
dist-s390x-linux: 5475.1s -> 5143.7s (-6.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-29T09:09:50Z

Finished benchmarking commit (5f025f3): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.2%]	8
Regressions ❌ (secondary)	0.3%	[0.2%, 0.5%]	20
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.3%]	5
Improvements ✅ (secondary)	-2.5%	[-5.7%, -0.2%]	10
All ❌✅ (primary)	-0.0%	[-0.4%, 0.2%]	13

Max RSS (memory usage)

Results (primary -1.4%, secondary -5.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[1.5%, 3.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-9.4%	[-9.4%, -9.4%]	1
Improvements ✅ (secondary)	-5.6%	[-5.6%, -5.6%]	1
All ❌✅ (primary)	-1.4%	[-9.4%, 3.6%]	3

Cycles

Results (secondary 9.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	15.8%	[14.0%, 17.9%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-4.7%, -3.7%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.76s -> 777.949s (-0.10%)
Artifact size: 368.56 MiB -> 368.50 MiB (-0.02%)

Mark-Simulacrum · 2025-06-02T12:26:46Z

I think this perf improvement is a wash, but it's beneficial for nalgebra in the new and old solvers, so I'm still inclined to land it. Maybe some follow-up perf work can be done to tweak inlining and/or remove unnecessary folding is warranted :>

Marking as triaged.

add more `TypeFlags` fast paths, cache `param_env` canonicalization BLocked on #141581

cache `param_env` canonicalization BLocked on #141581

cache `param_env` canonicalization BLocked on rust-lang/rust#141581

rustbot assigned compiler-errors May 26, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 26, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 26, 2025

lcnr commented May 26, 2025

View reviewed changes

lcnr mentioned this pull request May 26, 2025

cache param_env canonicalization #141451

Merged

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 26, 2025

lcnr added 2 commits May 26, 2025 19:57

add additional TypeFlags fast paths

c56efae

assert we never incorrectly canonicalize envs

0830ce0

compiler-errors force-pushed the fold-clauses branch from 1a2a21a to 0830ce0 Compare May 26, 2025 19:58

compiler-errors approved these changes May 26, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 26, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 27, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 29, 2025

bors merged commit 5f025f3 into rust-lang:master May 29, 2025
8 checks passed

rustbot added this to the 1.89.0 milestone May 29, 2025

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jun 2, 2025

rust-bors bot added a commit that referenced this pull request Jun 9, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=<try>

eb709e5

add more `TypeFlags` fast paths, cache `param_env` canonicalization BLocked on #141581

bors added a commit that referenced this pull request Jun 10, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=compiler-errors

100199c

cache `param_env` canonicalization BLocked on #141581

lcnr deleted the fold-clauses branch June 10, 2025 14:28

github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 12, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=compiler-errors

dd01be4

cache `param_env` canonicalization BLocked on rust-lang/rust#141581

tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Jun 14, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=compiler-errors

58af319

cache `param_env` canonicalization BLocked on rust-lang/rust#141581

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 14, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=compiler-errors

6751b23

cache `param_env` canonicalization BLocked on rust-lang/rust#141581

add additional TypeFlags fast paths #141581

add additional TypeFlags fast paths #141581

Uh oh!

Conversation

lcnr commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 26, 2025

Uh oh!

lcnr commented May 26, 2025

Uh oh!

This comment has been minimized.

bors commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented May 26, 2025

Uh oh!

This comment has been minimized.

rust-timer commented May 26, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

compiler-errors commented May 26, 2025

Uh oh!

compiler-errors commented May 26, 2025

Uh oh!

bors commented May 26, 2025

Uh oh!

compiler-errors commented May 26, 2025

Uh oh!

compiler-errors commented May 26, 2025

Uh oh!

compiler-errors commented May 26, 2025

Uh oh!

This comment has been minimized.

bors commented May 26, 2025

Uh oh!

bors commented May 27, 2025

Uh oh!

This comment has been minimized.

rust-timer commented May 27, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

compiler-errors commented May 28, 2025

Uh oh!

bors commented May 28, 2025

Uh oh!

bors commented May 29, 2025

Uh oh!

bors commented May 29, 2025

Uh oh!

Uh oh!

github-actions bot commented May 29, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 29, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Mark-Simulacrum commented Jun 2, 2025

Uh oh!

Uh oh!

add additional `TypeFlags` fast paths #141581

add additional `TypeFlags` fast paths #141581

lcnr commented May 26, 2025 •

edited

Loading