Skip to content

allow macro_use as first segment #141884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/rustc_passes/src/check_attr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2312,7 +2312,9 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
}

fn check_macro_use(&self, hir_id: HirId, attr: &Attribute, target: Target) {
let name = attr.name().unwrap();
let Some(name) = attr.name() else {
return;
};
match target {
Target::ExternCrate | Target::Mod => {}
_ => {
Expand Down
3 changes: 0 additions & 3 deletions tests/crashes/140255.rs

This file was deleted.

7 changes: 7 additions & 0 deletions tests/ui/attributes/auxiliary/external-macro-use.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
extern crate proc_macro;
use proc_macro::*;

#[proc_macro_attribute]
pub fn a(_: TokenStream, input: TokenStream) -> TokenStream {
input
}
15 changes: 15 additions & 0 deletions tests/ui/attributes/illegal-macro-use.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// issue#140255

#[macro_use::a] //~ ERROR failed to resolve: use of unresolved module or unlinked crate `macro_use`
fn f0() {}

#[macro_use::a::b] //~ ERROR failed to resolve: use of unresolved module or unlinked crate `macro_use`
fn f1() {}

#[macro_escape::a] //~ ERROR failed to resolve: use of unresolved module or unlinked crate `macro_escape`
fn f2() {}

#[macro_escape::a::b] //~ ERROR failed to resolve: use of unresolved module or unlinked crate `macro_escape`
fn f3() {}

fn main() {}
27 changes: 27 additions & 0 deletions tests/ui/attributes/illegal-macro-use.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
error[E0433]: failed to resolve: use of unresolved module or unlinked crate `macro_escape`
--> $DIR/illegal-macro-use.rs:12:3
|
LL | #[macro_escape::a::b]
| ^^^^^^^^^^^^ use of unresolved module or unlinked crate `macro_escape`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `macro_escape`
--> $DIR/illegal-macro-use.rs:9:3
|
LL | #[macro_escape::a]
| ^^^^^^^^^^^^ use of unresolved module or unlinked crate `macro_escape`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `macro_use`
--> $DIR/illegal-macro-use.rs:6:3
|
LL | #[macro_use::a::b]
| ^^^^^^^^^ use of unresolved module or unlinked crate `macro_use`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `macro_use`
--> $DIR/illegal-macro-use.rs:3:3
|
LL | #[macro_use::a]
| ^^^^^^^^^ use of unresolved module or unlinked crate `macro_use`

error: aborting due to 4 previous errors

For more information about this error, try `rustc --explain E0433`.
11 changes: 11 additions & 0 deletions tests/ui/attributes/use-extern-crate-named-macro-use.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//@ check-pass
//@ proc-macro: external-macro-use.rs

// issue#140255

extern crate external_macro_use as macro_use;

#[macro_use::a]
fn f() {}

fn main() {}
Loading