Build rustc with assertions in `dist-alt` jobs #142235

Kobzol · 2025-06-09T09:12:35Z

Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux -alt builds.

r? @ghost

try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt

rustbot · 2025-06-09T09:12:40Z

Some changes occurred in src/tools/opt-dist

cc @Kobzol

Kobzol · 2025-06-09T09:12:41Z

@bors2 try

rust-bors · 2025-06-09T09:12:45Z

⌛ Trying commit fea114c with merge 719c0f0…

To cancel the try build, run the command @bors2 try cancel.

Rustc dist alt assertions Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt

rust-bors · 2025-06-09T12:30:55Z

☀️ Try build successful (CI)
Build commit: 719c0f0 (719c0f0e93c1f3606edfa5381222b9d9b8b0c087)

Kobzol · 2025-06-09T12:34:58Z

@bors2 try

rust-bors · 2025-06-09T12:35:01Z

⌛ Trying commit 6d4df2d with merge 6acdc26…

To cancel the try build, run the command @bors2 try cancel.

Build rustc with assertions in `dist-alt` jobs Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt

rust-bors · 2025-06-09T15:06:30Z

☀️ Try build successful (CI)
Build commit: 6acdc26 (6acdc261c9a2a67217d87dea62949057a09f503f)

Kobzol · 2025-06-09T15:08:27Z

2h 14 minutes with the 8-core runner, pretty nice. @marcoieni would you be fine to switch the dist-alt runner to 8 cores in order to get rustc assertions in CI builds?

src/tools/opt-dist/src/main.rs

marcoieni · 2025-06-09T15:32:20Z

2h 14 minutes with the 8-core runner, pretty nice. @marcoieni would you be fine to switch the dist-alt runner to 8 cores in order to get rustc assertions in CI builds?

yes it's fine 👍

llvm assertions are already enabled and debug assertions are also useful

Kobzol · 2025-06-10T10:18:30Z

@bors2 try

Build rustc with assertions in `dist-alt` jobs Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt

rust-bors · 2025-06-10T10:18:34Z

⌛ Trying commit 607a567 with merge 11c9e81…

To cancel the try build, run the command @bors2 try cancel.

rust-bors · 2025-06-10T12:48:42Z

☀️ Try build successful (CI)
Build commit: 11c9e81 (11c9e81093a637885ff88d565c318d0b9c074c63)

Kobzol · 2025-06-10T13:00:53Z

r? @marcoieni

marcoieni · 2025-06-10T13:03:09Z

@bors r+

bors · 2025-06-10T13:03:12Z

📌 Commit 607a567 has been approved by marcoieni

It is now in the queue for this repository.

…r=marcoieni Build rustc with assertions in `dist-alt` jobs Revival of rust-lang#131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds. r? `@ghost` try-job: dist-x86_64-msvc-alt try-job: dist-x86_64-linux-alt

Rollup of 13 pull requests Successful merges: - #128425 (Make `missing_fragment_specifier` an unconditional error) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142235 (Build rustc with assertions in `dist-alt` jobs) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) Failed merges: - #141942 (Implement representation options to smir) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2025-06-12T05:10:47Z

sorry, I don't have a good reason, it just has a vibe, and I think everyone else is assuming it does too.

@bors rollup=iffy

bors · 2025-06-14T01:59:41Z

⌛ Testing commit 607a567 with merge 64c81fd...

bors · 2025-06-14T04:57:15Z

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing 64c81fd to master...

github-actions · 2025-06-14T05:00:27Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d087f11 (parent) -> 64c81fd (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 64c81fd10509924ca4da5d93d6052a65b75418a5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 3428.9s -> 5893.1s (71.9%)
dist-x86_64-apple: 7706.6s -> 9773.4s (26.8%)
dist-x86_64-linux-alt: 9526.9s -> 7293.1s (-23.4%)
aarch64-apple: 4330.2s -> 5259.7s (21.5%)
dist-x86_64-msvc-alt: 7142.8s -> 8375.8s (17.3%)
aarch64-gnu-debug: 3575.9s -> 4064.3s (13.7%)
dist-arm-linux-gnueabi: 4555.5s -> 5160.7s (13.3%)
x86_64-apple-1: 6185.4s -> 6946.8s (12.3%)
i686-gnu-2: 5391.9s -> 6044.3s (12.1%)
mingw-check-1: 1677.9s -> 1860.1s (10.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-14T06:24:31Z

Finished benchmarking commit (64c81fd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%, secondary -5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-3.6%, -1.6%]	2
Improvements ✅ (secondary)	-5.7%	[-8.2%, -3.3%]	2
All ❌✅ (primary)	-2.6%	[-3.6%, -1.6%]	2

Cycles

Results (secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.156s -> 757.551s (0.05%)
Artifact size: 372.29 MiB -> 372.30 MiB (0.00%)

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 9, 2025

Kobzol changed the title ~~Rustc dist alt assertions~~ Build rustc with assertions in dist-alt jobs Jun 9, 2025

marcoieni reviewed Jun 9, 2025

View reviewed changes

src/tools/opt-dist/src/main.rs Outdated Show resolved Hide resolved

lqd and others added 2 commits June 10, 2025 12:17

enable rustc debug assertions on -alt builds

8f069e9

llvm assertions are already enabled and debug assertions are also useful

Use a faster runner for the x64 dist-alt job

607a567

Kobzol force-pushed the rustc-dist-alt-assertions branch from 6d4df2d to 607a567 Compare June 10, 2025 10:17

rustbot assigned marcoieni Jun 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025

fmease mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142313

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2025

bors merged commit 64c81fd into rust-lang:master Jun 14, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 14, 2025

Kobzol deleted the rustc-dist-alt-assertions branch June 14, 2025 06:18

Build rustc with assertions in dist-alt jobs #142235

Build rustc with assertions in dist-alt jobs #142235

Uh oh!

Conversation

Kobzol commented Jun 9, 2025

Uh oh!

rustbot commented Jun 9, 2025

Uh oh!

Kobzol commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

Kobzol commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

Kobzol commented Jun 9, 2025

Uh oh!

Uh oh!

marcoieni commented Jun 9, 2025

Uh oh!

Kobzol commented Jun 10, 2025

Uh oh!

rust-bors bot commented Jun 10, 2025

Uh oh!

rust-bors bot commented Jun 10, 2025

Uh oh!

Kobzol commented Jun 10, 2025

Uh oh!

marcoieni commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

workingjubilee commented Jun 12, 2025

Uh oh!

bors commented Jun 14, 2025

Uh oh!

bors commented Jun 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 14, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 14, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Build rustc with assertions in `dist-alt` jobs #142235

Build rustc with assertions in `dist-alt` jobs #142235