Skip to content

Add lint rule for #[deprecated] on re-exports (rebase) #142731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jun 19, 2025

Rebase of #132038

Original description:

As reported in #30827 and #84584, marking a re-export (pub use) with #[deprecated] does not produce a warning for consumers. In fact, there are instances of this in the core and std crates (see past issue #82080 where this caused some confusion).

This change modifies the stability annotation visitor to mark #[deprecated] annotations on use statements with AnnotationKind::DeprecationProhibited so that library developers are aware that the annotation is not warning their users as expected.

#[deprecated]
pub use a_module::ActiveType;
error: this `#[deprecated]` annotation has no effect
  --> $DIR/deprecated_use.rs:6:1
   |
LL | #[deprecated]
   | ^^^^^^^^^^^^^ help: remove the unnecessary deprecation attribute
   |
   = note: `#[deny(useless_deprecated)]` on by default

error: aborting due to 1 previous error

Closes #142436 (I think)

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2025

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn that #[deprecated] does not work on re-exports
5 participants