Skip to content

Fix ICE on debug builds where lints are delayed on the crate root #142892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

Fix ICE on debug builds where lints are delayed on the crate root #142892

merged 2 commits into from
Jun 23, 2025

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Jun 22, 2025 •
edited
Loading

r? @oli-obk

Closes #142891

thanks to @JonathanBrouwer for finding it!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jun 23, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 8ee2d2e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
bjorn3
bjorn3 reviewed Jun 23, 2025
View reviewed changes
tests/ui/attributes/lint_on_root.rs Outdated
@@ -0,0 +1,7 @@
// NOTE: this used to panic in debug builds (by a sanety assertion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// NOTE: this used to panic in debug builds (by a sanety assertion)
// NOTE: this used to panic in debug builds (by a sanity assertion)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lemme fix that and r+ again

@jdonszelmann
Copy link
Contributor Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2025
@jdonszelmann
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 269b67d has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2025
@bjorn3
Copy link
Member

bjorn3 commented Jun 23, 2025

@bors r-
@bors r=oli-obk

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2025
@bors
Copy link
Collaborator

bors commented Jun 23, 2025

📌 Commit 269b67d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2025
@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Jun 23, 2025 •
edited
Loading

oh sorry, thanks bjorn!

jdonszelmann added a commit to jdonszelmann/rust that referenced this pull request Jun 23, 2025
@jdonszelmann
Rollup merge of rust-lang#142892 - jdonszelmann:fix-142891, r=oli-obk
864a0e5 
Fix ICE on debug builds where lints are delayed on the crate root

r? `@oli-obk`

Closes rust-lang#142891

thanks to `@JonathanBrouwer` for finding it!
This was referenced Jun 23, 2025
Closed
Merged
bors added a commit that referenced this pull request Jun 23, 2025
@bors
Auto merge of #142906 - jdonszelmann:rollup-togt1dl, r=jdonszelmann
42245d3 
Rollup of 5 pull requests

Successful merges:

 - #142493 (rework `#[naked]` attribute parser)
 - #142636 (bootstrap.example.toml: use less contextual format)
 - #142822 (Make `PartialEq` a `const_trait`)
 - #142892 (Fix ICE on debug builds where lints are delayed on the crate root)
 - #142904 (notify me when rdg is touched)

Failed merges:

 - #142827 (Move error code explanation removal check into tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6cee0a6 into rust-lang:master Jun 23, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 23, 2025
rust-timer added a commit that referenced this pull request Jun 23, 2025
@rust-timer
Unrolled build for #142892
eb7420c 
Rollup merge of #142892 - jdonszelmann:fix-142891, r=oli-obk

Fix ICE on debug builds where lints are delayed on the crate root

r? ``@oli-obk``

Closes #142891

thanks to ``@JonathanBrouwer`` for finding it!
@cuviper cuviper modified the milestones: 1.89.0, 1.90.0 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.

Broken inner inline attribute causes ICE
6 participants
@jdonszelmann @oli-obk @bors @bjorn3 @cuviper @rustbot