Rollup of 9 pull requests #143147
Closed
Rollup of 9 pull requests #143147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows to have a tigher control over the binding exclusivness of the socket.
mostly for #[non_exhaustive]
The method `BTreeSet::from_sorted_iter` was introduced in 49ccb75, but it was not consistently used throughout the codebase. As a result, some code redundantly reimplemented its logic. This commit fixes the problem.
… r=Mark-Simulacrum std::net: adding `unix_socket_exclbind` feature for solaris/illumos. allows to have a tigher control over the binding exclusivness of the socket. ACP: rust-lang/libs-team#366
… r=Mark-Simulacrum Do not include NUL-terminator in computed length This PR contains just the first commit of rust-lang#142579 which changes it so that the string length stored in the `Location` is the length of the `&str` rather than the length of the `&CStr`. Since most users will want the `&str` length, it seems better to optimize for that use-case. There should be no visible changes in the behavior or API.
Skip unnecessary components in x64 try builds We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components. r? ``@jieyouxu``
…e-enum-v-142599, r=GuillaumeGomez rustdoc: show attributes on enum variants mostly for #[non_exhaustive] unsure if there's any attributes we should take care to *not* include, it could use `render_code_attribute` and `is_non_exhaustive` instead, if that is a concern. fixes rust-lang#142599
…Simulacrum Add windows-gnullvm hosts to the manifest I made a mistake testing rust-lang#140772 only with `rustup-toolchain-install-master` which doesn't care about the manifests. This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.
…t, r=Mark-Simulacrum update internal `send_signal` comment the vxwork did not have the old comment updated in rust-lang#141990 so update here; signaling -> sending signals to because the latter reads better to me.
…, r=nnethercote Use tidy to sort `sym::*` items Use tidy to sort the symbols in the invocation of `symbols!`, instead of implementing the ordering check inside the proc macro. (asked ``@nnethercote`` about this on zulip, he didn't have any reservations about making this change) This has a couple of benefits: - tidy's "version sort" (thanks to rust-lang#141311 !) is nicer than the naive-cmp sort, so, e.g. `AtomicI{8, 16, 32, 64, 128}` are properly sorted by bit width. - consistency with the rest of the repo - allows us to remove a bit of order-verifying code from the `symbols!` proc macro impl
…k-Simulacrum BTreeSet: remove duplicated code by reusing `from_sorted_iter` The method `BTreeSet::from_sorted_iter` was introduced in 49ccb75, but it was not consistently used throughout the codebase. As a result, some code redundantly reimplemented its logic. This commit fixes the problem.
Minor Documentation Improvements --- ## Description - Fixed typos and improved clarity in comments and documentation. ---
rustbot
added
A-testsuite
rustbot
added
T-rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
unix_socket_exclbindfeature for solaris/illumos. #123476 (std::net: addingunix_socket_exclbindfeature for solaris/illumos.)send_signalcomment #143082 (update internalsend_signalcomment)sym::*items #143110 (Use tidy to sortsym::*items)from_sorted_iter#143111 (BTreeSet: remove duplicated code by reusingfrom_sorted_iter)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup