Skip to content

Rewrite empty attribute lint for new attribute parser #143252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2025
Merged

Rewrite empty attribute lint for new attribute parser #143252

merged 2 commits into from
Jul 6, 2025

Conversation

JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jun 30, 2025 •
edited
Loading

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 1, 2025
Merged
@bors
Copy link
Collaborator

bors commented Jul 3, 2025

☔ The latest upstream changes (presumably #143338) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 3, 2025
jdonszelmann
jdonszelmann reviewed Jul 3, 2025
View reviewed changes
@JonathanBrouwer JonathanBrouwer force-pushed the rewrite_empty_attribute branch from bdb57ed to b896b59 Compare July 4, 2025 10:42
@JonathanBrouwer JonathanBrouwer marked this pull request as ready for review July 4, 2025 10:42
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

@JonathanBrouwer
Copy link
Contributor Author

^ Rebased on master and fixed the review comments, changed quite a bit so would recommend to rereview
@rustbot ready
r? @jdonszelmann

@rustbot rustbot assigned jdonszelmann and unassigned fee1-dead Jul 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

jdonszelmann is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer JonathanBrouwer force-pushed the rewrite_empty_attribute branch from b896b59 to a577ea0 Compare July 4, 2025 11:40
@bors
Copy link
Collaborator

bors commented Jul 4, 2025

☔ The latest upstream changes (presumably #143434) made this pull request unmergeable. Please resolve the merge conflicts.

@JonathanBrouwer JonathanBrouwer force-pushed the rewrite_empty_attribute branch 2 times, most recently from 6cdec3b to fd443fc Compare July 5, 2025 06:48
@JonathanBrouwer
Copy link
Contributor Author

^ @jdonszelmann rebased on master

jdonszelmann
jdonszelmann requested changes Jul 5, 2025
View reviewed changes
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2025
Closed
@JonathanBrouwer
Copy link
Contributor Author

@rustbot ready
@jdonszelmann You can r+ this if you want but it's definitely gonna conflict with #143238, I'll ping you after that one goes through and I rebased this on it

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2025
@JonathanBrouwer JonathanBrouwer force-pushed the rewrite_empty_attribute branch from 3bab1c5 to 33f2cc7 Compare July 6, 2025 07:51
@JonathanBrouwer
Copy link
Contributor Author

^ @jdonszelmann rebased

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 6, 2025

📌 Commit 33f2cc7 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 6, 2025
Merged
bors added a commit that referenced this pull request Jul 6, 2025
@bors
Auto merge of #143526 - matthiaskrgr:rollup-pm69g5v, r=matthiaskrgr
de031bb 
Rollup of 4 pull requests

Successful merges:

 - #143252 (Rewrite empty attribute lint for new attribute parser)
 - #143492 (Use `object` crate from crates.io to fix windows build error)
 - #143514 (Organize macro tests a bit more)
 - #143518 (rustc_builtin_macros: Make sure registered attributes stay sorted)

r? `@ghost`
`@rustbot` modify labels: rollup
@jdonszelmann jdonszelmann mentioned this pull request Jul 6, 2025
Closed
@compiler-errors
Copy link
Member

This fixes #143522 so it would be nice to add a test either here or a follow-up.

@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 6, 2025
Closed
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jul 6, 2025 •
edited
Loading

@compiler-errors
This PR is already being merged right now so it will be a followup. I was already gonna make a followup for #143479 which is in the same situation (fixed by this PR, no tests) as #143522

@bors bors merged commit 017fe2f into rust-lang:master Jul 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 6, 2025
rust-timer added a commit that referenced this pull request Jul 6, 2025
@rust-timer
Unrolled build for #143252
6c1641c 
Rollup merge of #143252 - JonathanBrouwer:rewrite_empty_attribute, r=jdonszelmann

Rewrite empty attribute lint for new attribute parser

cc `@jdonszelmann`
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 6, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#143539 - JonathanBrouwer:ice-regression-tes…
6c8482e 
…ts, r=oli-obk

Regression tests for repr ICEs

Closes rust-lang#143522
Closes rust-lang#143479

Both issues were already (accidentally) fixed in this PR, but having the tests is nice rust-lang#143252

r? `@jdonszelmann`
rust-timer added a commit that referenced this pull request Jul 7, 2025
@rust-timer
Unrolled build for #143539
a0f4a62 
Rollup merge of #143539 - JonathanBrouwer:ice-regression-tests, r=oli-obk

Regression tests for repr ICEs

Closes #143522
Closes #143479

Both issues were already (accidentally) fixed in this PR, but having the tests is nice #143252

r? `@jdonszelmann`
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 15, 2025
@matthiaskrgr
Rollup merge of #143539 - JonathanBrouwer:ice-regression-tests, r=oli…
d6dc3d9 
…-obk

Regression tests for repr ICEs

Closes rust-lang/rust#143522
Closes rust-lang/rust#143479

Both issues were already (accidentally) fixed in this PR, but having the tests is nice rust-lang/rust#143252

r? `@jdonszelmann`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonszelmann jdonszelmann jdonszelmann requested changes

Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@JonathanBrouwer @bors @rustbot @rust-log-analyzer @jdonszelmann @compiler-errors @fee1-dead