Remove duplicate error about raw underscore lifetime #143280
Open
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Jul 1, 2025
|
r? compiler-errors |
I have a try on it, and it works. |
Signed-off-by: xizheyin <[email protected]>
xizheyin
commented
Jul 1, 2025
Comment on lines
+2905
to
+2914
| // To avoid emitting two duplicate errors, we need to check if the span is a raw underscore lifetime, see issue #143152 | ||
| let is_raw_underscore = self | ||
| .r | ||
| .tcx | ||
| .sess | ||
| .psess | ||
| .raw_identifier_spans | ||
| .iter() | ||
| .any(|span| span == param.span()); | ||
| if param.ident.name == kw::UnderscoreLifetime && !is_raw_underscore { |
There was a problem hiding this comment.
I'm wondering if I should split it into 2 parts, as this doesn't seem very aesthetically pleasing taking up so many lines. However it seems to give the wrong impression that the variable in the middle will be used multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143152
r? @fee1-dead