Update the `compiler-builtins` subtree #143405

tgross35 · 2025-07-03T23:52:49Z

Update the Josh subtree to rust-lang/compiler-builtins@8aba4c899ee8.

…tion

This PR adds a minimal `triagebot.toml` config to make contributions to this repository respect upstream rust-lang/rust conventions and avoid issues when syncing this subtree.

Rather than re-opening the archive file for each check, add a wrapper that keeps the data in memory. Additionally, collect the `--target` argument so it can be used within this crate.

cc https://www.github.com/rust-lang/rust/issues/140364

Often our short summaries will pick up a Bors "Auto merge of #xxxx ...` commit message. Replace these with something like `rust-lang#1234` to avoid broken links when going between repositories.

…i256 and u256 `i256` and `u256` - operators now use the same overflow convention as primitives - implement `<<` and `-` (previously just `>>` and `+`) - implement `Ord` correctly (the previous `PartialOrd` was broken) - correct `i256::SIGNED` to `true` The `Int`-trait is extended with `trailing_zeros`, `carrying_add`, and `borrowing_sub`.

Currently we whether or not to build and test `f16` and `f128` support mostly based on the target triple. This isn't always accurate, however, since support also varies by backend and the backend version. Since recently, `rustc` is aware of this with the unstable config option `target_has_reliable_{f16,f128}`, which better represents when the types are actually expected to be available and usable. Switch our compiler-builtins and libm configuration to use this by probing `rustc` for the target's settings. A few small `cfg` fixes are needed with this.

tgross35 · 2025-07-03T23:54:48Z

@bors r+ rollup=never

bors · 2025-07-03T23:54:51Z

📌 Commit be35d37 has been approved by tgross35

It is now in the queue for this repository.

Update the `compiler-builtins` subtree Update the Josh subtree to rust-lang/compiler-builtins@ed17b95715dd. r? `@ghost`

bors · 2025-07-04T13:24:59Z

⌛ Testing commit be35d37 with merge a6503b1...

bors · 2025-07-04T14:36:23Z

💔 Test failed - checks-actions

This makes it more obvious what we intend to check rather than looking for `--target`.

Rather than printing the entire JSON dump, use the rendered version.

8521530f4938 ("Fix __divsi3 and __udivsi3 on thumbv6m targets") removed tests that use these `thumb*-linux` target files in favor of tests that use the `thumb*-none` targets, which are available via Rustup. The JSON files haven't been used since then and are outdated, so remove them.

The `rustc` probe done in our build scripts needs to pass `--target` to get the correct configuration, which usually comes from the `TARGET` environment variable. However, for targets specified via a `target.json` file, `TARGET` gets set to the file name without an extension or path. `rustc` will check a search path to attempt to locate the file, but this is likely to fail since the directory where Cargo invokes build scripts (and hence where those scripts invoke `rustc`) might not have any relation to the JSON spec file. Resolve this for now by leaving `f16` and `f128` disabled if the `rustc` command fails. Result of the discussion at CARGO-14208 may eventually provide a better solution. A CI test is also added since custom JSON files are an edge case that could fail in other ways. I verified this fails without the fix here. The JSON file is the output for `thumbv7em-none-eabi`, just renamed so `rustc` doesn't identify it.

tgross35 · 2025-07-05T03:11:34Z

@bors r+

bors · 2025-07-05T03:11:36Z

📌 Commit 016bc61 has been approved by tgross35

It is now in the queue for this repository.

rust-bors · 2025-07-05T09:39:45Z

☀️ Try build successful (CI)
Build commit: 4b5fb38 (4b5fb38fd87852634931b0ddfa4ca9dd7895c842, parent: 733b47ea4b1b86216f14ef56e49440c33933f230)

tgross35 · 2025-07-09T10:43:39Z

MinGW fix merged in #143475
@bors r+

bors · 2025-07-09T10:43:42Z

📌 Commit 016bc61 has been approved by tgross35

It is now in the queue for this repository.

bors · 2025-07-09T14:02:23Z

⌛ Testing commit 016bc61 with merge fd2e8b9...

Update the `compiler-builtins` subtree Update the Josh subtree to rust-lang/compiler-builtins@8aba4c899ee8. r? `@ghost`

rust-log-analyzer · 2025-07-09T16:34:04Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2025-07-09T14:47:55Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2025-07-09T14:47:55Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None, backend=Llvm, target=X86_64UnknownLinuxGnu, phase=benchmark
[2025-07-09T14:47:55Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/Users/RUNNER~1/AppData/Local/Temp/.tmpgTtMxH#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2025-07-09T14:47:56Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None, backend=Llvm, target=X86_64UnknownLinuxGnu, phase=benchmark
[2025-07-09T14:47:56Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/Users/RUNNER~1/AppData/Local/Temp/.tmpgTtMxH#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmpgTtMxH\\incremental-state"
[2025-07-09T14:47:57Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, target=X86_64UnknownLinuxGnu, phase=benchmark
[2025-07-09T14:47:57Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/Users/RUNNER~1/AppData/Local/Temp/.tmpgTtMxH#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmpgTtMxH\\incremental-state"
[2025-07-09T14:47:58Z DEBUG collector::compile::benchmark] applying patch println
[2025-07-09T14:47:58Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmpgTtMxH"
[2025-07-09T14:47:58Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, target=X86_64UnknownLinuxGnu, phase=benchmark
[2025-07-09T14:47:58Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/Users/RUNNER~1/AppData/Local/Temp/.tmpgTtMxH#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmpgTtMxH\\incremental-state"
Running bitmaps-3.2.1: Debug + [Full, IncrFull, IncrUnchanged, IncrPatched] + Llvm + X86_64UnknownLinuxGnu
[2025-07-09T14:47:59Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2025-07-09T14:47:59Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, target=X86_64UnknownLinuxGnu, phase=benchmark
[2025-07-09T14:47:59Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/Users/RUNNER~1/AppData/Local/Temp/.tmpF6eo83#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2025-07-09T14:48:00Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, target=X86_64UnknownLinuxGnu, phase=benchmark

bors · 2025-07-09T16:34:33Z

💔 Test failed - checks-actions

Kobzol · 2025-07-09T16:36:10Z

@bors treeclosed-

tgross35 · 2025-07-09T19:07:16Z

@bors2 try jobs=dist-x86_64-msvc

rust-bors · 2025-07-09T19:07:21Z

⌛ Trying commit 016bc61 with merge 608083e…

To cancel the try build, run the command @bors2 try cancel.

Update the `compiler-builtins` subtree Update the Josh subtree to rust-lang/compiler-builtins@8aba4c899ee8. r? `@ghost` try-job: dist-x86_64-msvc

rust-bors · 2025-07-09T21:38:30Z

☀️ Try build successful (CI)
Build commit: 608083e (608083e5747ea65e66b16789ff905aeb5280a427, parent: 6b3ae3f6e45a33c2d95fa0362c9b2593e567fd34)

tgross35 · 2025-07-09T21:39:28Z

Spurious?
@bors r+

bors · 2025-07-09T21:39:31Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Instantiate auto trait/Copy/Clone/Sized before computing constituent types binder #143538

bors · 2025-07-09T21:39:32Z

📌 Commit 016bc61 has been approved by tgross35

It is now in the queue for this repository.

bors · 2025-07-09T22:42:15Z

⌛ Testing commit 016bc61 with merge 607fbd8...

bors · 2025-07-10T01:43:54Z

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 607fbd8 to master...

github-actions · 2025-07-10T01:46:57Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e43d139 (parent) -> 607fbd8 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 607fbd8d3e25997737a0bf25b215e581b922f1b0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 8089.3s -> 5716.5s (-29.3%)
x86_64-apple-2: 4041.6s -> 5222.1s (29.2%)
pr-check-2: 2496.4s -> 2113.3s (-15.3%)
x86_64-gnu-tools: 3632.7s -> 3298.4s (-9.2%)
x86_64-gnu-llvm-20-1: 3664.6s -> 3364.8s (-8.2%)
x86_64-rust-for-linux: 2750.6s -> 2527.0s (-8.1%)
x86_64-gnu-debug: 5892.1s -> 5444.0s (-7.6%)
x86_64-gnu-distcheck: 8228.7s -> 7605.5s (-7.6%)
dist-apple-various: 5813.2s -> 6251.7s (7.5%)
i686-msvc-1: 9884.7s -> 9155.8s (-7.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-10T02:53:37Z

Finished benchmarking commit (607fbd8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.0%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	4.1%	[1.8%, 6.0%]	6
Improvements ✅ (primary)	-2.0%	[-3.5%, -1.1%]	3
Improvements ✅ (secondary)	-2.9%	[-3.5%, -2.3%]	2
All ❌✅ (primary)	-1.0%	[-3.5%, 2.0%]	4

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.828s -> 464.395s (-0.09%)
Artifact size: 374.47 MiB -> 374.48 MiB (0.00%)

folkertdev and others added 9 commits June 14, 2025 13:10

use is_multiple_of to check if an addr is aligned

3dc3017

use extern "custom" on naked functions with a custom calling conven…

a413cca

…tion

Add minimal triagebot config

bcc96da

This PR adds a minimal `triagebot.toml` config to make contributions to this repository respect upstream rust-lang/rust conventions and avoid issues when syncing this subtree.

symcheck: Add a wrapper around an archive

9f4670f

Rather than re-opening the archive file for each check, add a wrapper that keeps the data in memory. Additionally, collect the `--target` argument so it can be used within this crate.

Use asm_cfg in probestack

962ff16

cc https://www.github.com/rust-lang/rust/issues/140364

apply suggestions for clippy::manual_is_multiple_of in libm-test

76b9fbf

josh-sync: Replace #xxxx-style links in messages

a4d584e

Often our short summaries will pick up a Bors "Auto merge of #xxxx ...` commit message. Replace these with something like `rust-lang#1234` to avoid broken links when going between repositories.

rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

tgross35 mentioned this pull request Jul 4, 2025

Improve commit message of pushes rust-lang/josh-sync#7

Merged

bors added a commit that referenced this pull request Jul 4, 2025

Auto merge of #143405 - tgross35:update-builtins, r=tgross35

a6503b1

Update the `compiler-builtins` subtree Update the Josh subtree to rust-lang/compiler-builtins@ed17b95715dd. r? `@ghost`

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 4, 2025

tgross35 added 5 commits July 4, 2025 16:53

Remove the let_chains feature now that it is stable

6ae56f4

symcheck: Make target a positional argument

e164811

This makes it more obvious what we intend to check rather than looking for `--target`.

symcheck: Improve diagnostics from spawned Cargo

84060f6

Rather than printing the entire JSON dump, use the rendered version.

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2025

tgross35 force-pushed the update-builtins branch from 082c119 to 016bc61 Compare July 9, 2025 10:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2025

bors added a commit that referenced this pull request Jul 9, 2025

Auto merge of #143405 - tgross35:update-builtins, r=tgross35

fd2e8b9

Update the `compiler-builtins` subtree Update the Josh subtree to rust-lang/compiler-builtins@8aba4c899ee8. r? `@ghost`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2025

rust-bors bot added a commit that referenced this pull request Jul 9, 2025

Auto merge of #143405 - tgross35:update-builtins, r=<try>

608083e

Update the `compiler-builtins` subtree Update the Josh subtree to rust-lang/compiler-builtins@8aba4c899ee8. r? `@ghost` try-job: dist-x86_64-msvc

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 10, 2025

bors merged commit 607fbd8 into rust-lang:master Jul 10, 2025
24 checks passed

rustbot added this to the 1.90.0 milestone Jul 10, 2025

tgross35 deleted the update-builtins branch July 10, 2025 01:45

Update the compiler-builtins subtree #143405

Update the compiler-builtins subtree #143405

Uh oh!

Conversation

tgross35 commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 4, 2025

Uh oh!

tgross35 commented Jul 5, 2025

Uh oh!

bors commented Jul 5, 2025

Uh oh!

rust-bors bot commented Jul 5, 2025

Uh oh!

tgross35 commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 9, 2025

Uh oh!

bors commented Jul 9, 2025

Uh oh!

rust-log-analyzer commented Jul 9, 2025

Uh oh!

bors commented Jul 9, 2025

Uh oh!

Kobzol commented Jul 9, 2025

Uh oh!

tgross35 commented Jul 9, 2025

Uh oh!

rust-bors bot commented Jul 9, 2025

Uh oh!

rust-bors bot commented Jul 9, 2025

Uh oh!

tgross35 commented Jul 9, 2025

Uh oh!

bors commented Jul 9, 2025

Uh oh!

bors commented Jul 9, 2025

Uh oh!

bors commented Jul 9, 2025

Uh oh!

bors commented Jul 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 10, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Update the `compiler-builtins` subtree #143405

Update the `compiler-builtins` subtree #143405

tgross35 commented Jul 3, 2025 •

edited

Loading

tgross35 commented Jul 9, 2025 •

edited

Loading