Skip to content

loop_match: fix 'no terminator on block' #143583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

loop_match: fix 'no terminator on block' #143583

merged 1 commit into from
Jul 7, 2025

Conversation

folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Jul 7, 2025 •
edited
Loading

tracking issue: #132306
fixes #143435
fixes #143204

The argument block was not properly closed on an error path.

r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2025
@bjorn3
Copy link
Member

bjorn3 commented Jul 7, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit 6d58a88 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 7, 2025
Merged
bors added a commit that referenced this pull request Jul 7, 2025
@bors
Auto merge of #143601 - matthiaskrgr:rollup-9iw2sqk, r=matthiaskrgr
a2d45f7 
Rollup of 9 pull requests

Successful merges:

 - #132469 (Do not suggest borrow that is already there in fully-qualified call)
 - #143340 (awhile -> a while where appropriate)
 - #143438 (Fix the link in `rustdoc.md`)
 - #143539 (Regression tests for repr ICEs)
 - #143566 (Fix `x86_64-unknown-netbsd` platform support page)
 - #143572 (Remove unused allow attrs)
 - #143583 (`loop_match`: fix 'no terminator on block')
 - #143584 (make `Machine::load_mir` infallible)
 - #143591 (Fix missing words in future tracking issue)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5df1f5 into rust-lang:master Jul 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 7, 2025
rust-timer added a commit that referenced this pull request Jul 7, 2025
@rust-timer
Unrolled build for #143583
f4a4ab9 
Rollup merge of #143583 - folkertdev:loop-match-no-terminator-on-block, r=bjorn3

`loop_match`: fix 'no terminator on block'

tracking issue: #132306
fixes #143435

The argument `block` was not properly closed on an error path.

r? `@bjorn3`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.

ICE: no terminator on block ICE: broken mir: bad assignment
4 participants
@folkertdev @bjorn3 @bors @rustbot