const heap: fix ICE on forgotten make_global

[RalfJung]

This fixes the ICE in code like this:

const BAR: *mut i32 = unsafe { intrinsics::const_allocate(4, 4) as *mut i32 };

To do this I unified the error handling for missing make_global with the existing interning error handling, which wasn't half as bad as we though it'd be in #143595.

This is based on #143595; only the last two commits are new.

• The first one implements the behavior change.
• The second is just refactoring, simplifying things so we can get rid of a single-use trait.

Cc @fee1-dead

Fixes #129233

[rustbot]

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

[fee1-dead]

tests/crashes/const_mut_ref_check_bypass.rs needs to be removed, also add "Fixes #129233" in the PR description

I'd r+ it but my PR is in queue. I can also cherry pick these commits and make it r=RalfJung,fee1-dead on my PR

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[RalfJung]

I can also cherry pick these commits and make it r=RalfJung,fee1-dead on my PR

Okay, let's do that. :)

[RalfJung]

Closing in favor of #143595.